You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/06 11:12:16 UTC

[GitHub] [spark] beliefer commented on pull request #30981: [SPARK-33947][SQL] String functions: Trim/Ltrim/Rtrim support byte array

beliefer commented on pull request #30981:
URL: https://github.com/apache/spark/pull/30981#issuecomment-755239332


   > Hm, what's the use case for this? this is trimming as if the byte array represents a string, but byte arrays aren't strings, and this gets into issues of what defines encoding and whitespace too.
   
   According the description of Postgre, btrim remove the longest bytes appearing in bytes from the start and end of bytes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org