You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/03 20:22:47 UTC
[GitHub] [airflow] potiuk opened a new pull request, #24816: Migrate our code to be compliant with PEP 563
potiuk opened a new pull request, #24816:
URL: https://github.com/apache/airflow/pull/24816
The Postponed eveluation of annotations PEP introduced ways we can
use Postoponed annotations from Python 3.10 and better syntax
for Optional types in Python 3.7.
This PR migrates our code to use that feature.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24816: Migrate our code to be compliant with PEP 563
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24816:
URL: https://github.com/apache/airflow/pull/24816#issuecomment-1176758841
Closing. We will re-do it properly :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24816: Migrate our code to be compliant with PEP 563
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24816:
URL: https://github.com/apache/airflow/pull/24816#issuecomment-1173432740
Yeah. This is really POC :) .
The PR is not really "mergable" - and I think it can be smaller (like most "__init__.py" do not need it, so we could make it smaller, also splitting would be entirely possiible if we decide it is a good thing (and what scope it should have).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #24816: Migrate our code to be compliant with PEP 563
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #24816: Migrate our code to be compliant with PEP 563
URL: https://github.com/apache/airflow/pull/24816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #24816: Migrate our code to be compliant with PEP 563
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #24816:
URL: https://github.com/apache/airflow/pull/24816#issuecomment-1173317103
I have been thinking about this, but never anticipated this to be done in one PR… this is impossible to review, Firefox even has trouble opening the *Files changed* tab 🤦 It’d be a good idea to split things into multiple (like 20 or something…) PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org