[jira] [Resolved] (SLING-2080) Minor improvements to authentication [patch]

["Felix Meschberger (Resolved) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved SLING-2080.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: API 2.2.4
                   Auth Core 1.0.8
                   Form Based Authentication 1.0.4
                   JCR Jackrabbit Access Manager 2.1.2
                   OpenID Authentication 1.0.4
         Assignee: Felix Meschberger

I have applied all patches and fixed the places according to you suggestion. So I think this can be resolved for now.
                
> Minor improvements to authentication [patch]
> --------------------------------------------
>
>                 Key: SLING-2080
>                 URL: https://issues.apache.org/jira/browse/SLING-2080
>             Project: Sling
>          Issue Type: Improvement
>          Components: API, Authentication, JCR
>    Affects Versions: OpenID Authentication 1.0.2, JCR Jackrabbit Access Manager 2.1.0, Form Based Authentication 1.0.2, Auth Core 1.0.6, API 2.2.2
>            Reporter: angela
>            Assignee: Felix Meschberger
>            Priority: Minor
>             Fix For: OpenID Authentication 1.0.4, JCR Jackrabbit Access Manager 2.1.2, Form Based Authentication 1.0.4, Auth Core 1.0.8, API 2.2.4
>
>         Attachments: SLING-2080.patch
>
>
> while having a look at the sling authentication code i fixed some javadoc errors, missing annotations and redundant/inconsistent code fragments that i came across... feel free to include the attached patch (or parts of it).
> there were two additional things i couldn't resolve:
> AbstractAuthenticationHandler#sendValid states: " // expressely tell we have no content but set content type"
> did you mean explicitly?
> FormAuthenticationHandler#AuthenticationStorage:
> in this interface and its implementing class the javadoc is broken and refers to CookieAuthData, CookieAuthenticationHandler, CookieExtractor, SessionExtractor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira