You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/01/17 04:12:42 UTC

Review Request 17028: Fix deadlock caused when Preemptor tries to secure SchedulerCoreImpl intrinsic lock.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17028/
-----------------------------------------------------------

Review request for Aurora and Joe Smith.


Bugs: AURORA-50
    https://issues.apache.org/jira/browse/AURORA-50


Repository: aurora


Description
-------

Fix deadlock caused when Preemptor tries to secure SchedulerCoreImpl intrinsic lock.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/async/Preemptor.java b190a003316358ca942e76462c3232b26676c450 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 7a88629abd4e660e5080c852312813db8a6d5256 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java b3f19cc5bf1d255f13685dcd462dda88d384a01b 
  src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java c09f8454928f32047cf36b29a88deada2dc099d7 

Diff: https://reviews.apache.org/r/17028/diff/


Testing
-------

./gradlew build


Thanks,

Bill Farner


Re: Review Request 17028: Fix deadlock caused when Preemptor tries to secure SchedulerCoreImpl intrinsic lock.

Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17028/#review32121
-----------------------------------------------------------

Ship it!


Ship It!

- Joe Smith


On Jan. 16, 2014, 7:18 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17028/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 7:18 p.m.)
> 
> 
> Review request for Aurora and Joe Smith.
> 
> 
> Bugs: AURORA-50
>     https://issues.apache.org/jira/browse/AURORA-50
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix deadlock caused when Preemptor tries to secure SchedulerCoreImpl intrinsic lock.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java b190a003316358ca942e76462c3232b26676c450 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 7a88629abd4e660e5080c852312813db8a6d5256 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java b3f19cc5bf1d255f13685dcd462dda88d384a01b 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java c09f8454928f32047cf36b29a88deada2dc099d7 
> 
> Diff: https://reviews.apache.org/r/17028/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 17028: Fix deadlock caused when Preemptor tries to secure SchedulerCoreImpl intrinsic lock.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17028/
-----------------------------------------------------------

(Updated Jan. 17, 2014, 3:18 a.m.)


Review request for Aurora and Joe Smith.


Changes
-------

Fixed formatting.


Bugs: AURORA-50
    https://issues.apache.org/jira/browse/AURORA-50


Repository: aurora


Description
-------

Fix deadlock caused when Preemptor tries to secure SchedulerCoreImpl intrinsic lock.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/async/Preemptor.java b190a003316358ca942e76462c3232b26676c450 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 7a88629abd4e660e5080c852312813db8a6d5256 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java b3f19cc5bf1d255f13685dcd462dda88d384a01b 
  src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java c09f8454928f32047cf36b29a88deada2dc099d7 

Diff: https://reviews.apache.org/r/17028/diff/


Testing
-------

./gradlew build


Thanks,

Bill Farner