You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "aIbrahiim (via GitHub)" <gi...@apache.org> on 2026/05/08 16:17:35 UTC
[PR] fix rrio teardown executor cleanup path [beam]
aIbrahiim opened a new pull request, #38417:
URL: https://github.com/apache/beam/pull/38417
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix rrio teardown executor cleanup path [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #38417:
URL: https://github.com/apache/beam/pull/38417#discussion_r3209930751
##########
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Call.java:
##########
@@ -270,34 +270,35 @@ public void teardown() throws UserCodeExecutionException {
Sleeper sleeper = configuration.getSleeperSupplier().get();
backoffIfNeeded(backOff, sleeper);
-
- if (!configuration.getShouldRepeat()) {
- incIfPresent(teardownCounter);
- setupTeardown.teardown();
- return;
- }
-
- Repeater<Void, Void> repeater =
- Repeater.<Void, Void>builder()
- .setBackOff(backOff)
- .setSleeper(sleeper)
- .setThrowableFunction(
- ignored -> {
- incIfPresent(teardownCounter);
- setupTeardown.teardown();
- return null;
- })
- .build()
- .withBackoffCounter(backoffCounter)
- .withSleeperCounter(sleeperCounter);
-
- repeater.apply(null);
-
- checkStateNotNull(executor).shutdown();
try {
- boolean ignored = executor.awaitTermination(3L, TimeUnit.SECONDS);
- } catch (InterruptedException ignored) {
- // Ignore the interrupt during teardown.
+ if (!configuration.getShouldRepeat()) {
+ incIfPresent(teardownCounter);
+ setupTeardown.teardown();
+ return;
+ }
+
+ Repeater<Void, Void> repeater =
+ Repeater.<Void, Void>builder()
+ .setBackOff(backOff)
+ .setSleeper(sleeper)
+ .setThrowableFunction(
+ ignored -> {
+ incIfPresent(teardownCounter);
+ setupTeardown.teardown();
+ return null;
+ })
+ .build()
+ .withBackoffCounter(backoffCounter)
+ .withSleeperCounter(sleeperCounter);
+
+ repeater.apply(null);
+ } finally {
+ checkStateNotNull(executor).shutdown();
+ try {
+ boolean ignored = executor.awaitTermination(3L, TimeUnit.SECONDS);
+ } catch (InterruptedException ignored) {
+ // Ignore the interrupt during teardown.
+ }
Review Comment:
Using `checkStateNotNull(executor)` in a `finally` block is risky. If `executor` is null (for example, if `setup()` failed before the executor was initialized), this will throw an `IllegalStateException`. In Java, an exception thrown in a `finally` block will suppress any exception thrown from the `try` block, making debugging difficult. It is safer to use a null check here to ensure `teardown()` is idempotent and doesn't mask other errors. Additionally, the result of `awaitTermination` can be called without assigning it to a variable, avoiding a potential name conflict with the catch parameter.
```java
if (executor != null) {
executor.shutdown();
try {
executor.awaitTermination(3L, TimeUnit.SECONDS);
} catch (InterruptedException ignored) {
// Ignore the interrupt during teardown.
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix rrio teardown executor cleanup path [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #38417:
URL: https://github.com/apache/beam/pull/38417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix rrio teardown executor cleanup path [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #38417:
URL: https://github.com/apache/beam/pull/38417#issuecomment-4407963082
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request improves the reliability of the RRIO teardown process by ensuring that the executor service is consistently shut down, even if an error occurs during the teardown execution. This prevents potential resource leaks by guaranteeing the cleanup path is always followed.
### Highlights
* **Executor Cleanup**: Wrapped the teardown logic in a try-finally block to ensure the executor is properly shut down regardless of whether the teardown operation succeeds or fails.
<details>
<summary><b>New Features</b></summary>
🧠You can now enable **Memory** (public preview) to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix rrio teardown executor cleanup path [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38417:
URL: https://github.com/apache/beam/pull/38417#issuecomment-4408551769
Assigning reviewers:
R: @Abacn for label java.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org