You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2019/02/14 20:21:00 UTC
[jira] [Commented] (SOLR-13253) SolrResourceLoader of an
IndexSchema should only be used for building the schema stuff
[ https://issues.apache.org/jira/browse/SOLR-13253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768686#comment-16768686 ]
David Smiley commented on SOLR-13253:
-------------------------------------
In the attached patch I went a bit further by removing SolrConfig from IndexSchema as well since it's problematic if an IndexSchema is going to be used from one core to another to refer to core stuff. The only piece really used was the Lucene Version.
> SolrResourceLoader of an IndexSchema should only be used for building the schema stuff
> --------------------------------------------------------------------------------------
>
> Key: SOLR-13253
> URL: https://issues.apache.org/jira/browse/SOLR-13253
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Schema and Analysis
> Reporter: David Smiley
> Priority: Minor
> Attachments: SOLR-13253.patch
>
>
> The IndexSchema has a SolrResourceLoader that's taken from a SolrConfig in its constructor. If this IndexSchema gets re-used across Solr cores (via "shareSchema" being true in solr.xml), and if this resourceLoader is used in the future from a core that differs from the core the schema was created from, bad things can happen (like a memory leak in SolrResourceLoader.waitingForResources). The resourceLoader here is only actually needed to help create the schema stuff, like analyzers. Once it's done, it isn't needed anymore. However our Solr code base is using this in other places that are not appropriate. It's a subtle problem as there's a confluence of circumstances that need to occur to trigger it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org