You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2023/05/30 17:20:28 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #35810: GH-35809: [C#] Improvements to the C interface.

pitrou commented on code in PR #35810:
URL: https://github.com/apache/arrow/pull/35810#discussion_r1210588958


##########
csharp/src/Apache.Arrow/C/CArrowArrayExporter.cs:
##########
@@ -15,16 +15,21 @@
 
 
 using System;
+using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 using Apache.Arrow.Memory;
 
 namespace Apache.Arrow.C
 {
     public static class CArrowArrayExporter
     {
+#if NET5_0_OR_GREATER

Review Comment:
   Perhaps add a comment explaining why this needs .Net 5.0+? Or will it be obvious to a C# developer?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org