[GitHub] [knox] risdenk commented on a change in pull request #63: KNOX-1801 - Master secret is incorrectly assumed when a custom truststore is not specified when clientauth is enabled

[GitBox <gi...@apache.org>]

risdenk commented on a change in pull request #63: KNOX-1801 - Master secret is incorrectly assumed when a custom truststore is not specified when clientauth is enabled
URL: https://github.com/apache/knox/pull/63#discussion_r262599673
 
 

 ##########
 File path: gateway-spi/src/main/java/org/apache/knox/gateway/services/security/SSLService.java
 ##########
 @@ -22,8 +22,9 @@
 import java.security.NoSuchAlgorithmException;
 import java.security.cert.CertificateException;
 
+import org.apache.knox.gateway.config.GatewayConfig;
 import org.apache.knox.gateway.services.Service;
 
 public interface SSLService extends Service {
-  Object buildSslContextFactory(String keystoreFileName, String keystoreType, String alias) throws KeyStoreException, IOException, CertificateException, NoSuchAlgorithmException;
+  Object buildSslContextFactory(GatewayConfig config) throws KeyStoreException, IOException, CertificateException, NoSuchAlgorithmException, AliasServiceException;
 
 Review comment:
   Question - Is there an exception that `KeystoreException`, `CertificateException`, `NoSuchAlgorithmException` all extend from? Seems weird to have to call them out individually. I don't think we should replace with just plain `Exception` either.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services