You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Yong Tang <yo...@outlook.com> on 2016/04/03 22:38:42 UTC

Review Request 45660: Fix non-printable chars in mesos source code.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45660/
-----------------------------------------------------------

Review request for mesos, haosdent huang and Kevin Klues.


Bugs: MESOS-4033
    https://issues.apache.org/jira/browse/MESOS-4033


Repository: mesos


Description
-------

Note: This is part of MESOS-4033: Add a commit hook for checking non-ascii characters
Note: The commit hook requires separate commits for libprocess and mesos.


Diffs
-----

  src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
  src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 
  src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 

Diff: https://reviews.apache.org/r/45660/diff/


Testing
-------

make check


Thanks,

Yong Tang

Re: Review Request 45660: Fix non-printable chars in mesos source code.

Posted by Yong Tang <yo...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45660/
-----------------------------------------------------------

(Updated April 3, 2016, 8:58 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.


Changes
-------

Update reviewer's list.


Bugs: MESOS-4033
    https://issues.apache.org/jira/browse/MESOS-4033


Repository: mesos


Description (updated)
-------

This is part of MESOS-4033: Add a commit hook for checking non-ascii characters.

This commit fix the non-printable characters in the following files:
src/slave/flags.cpp
src/uri/fetchers/curl.cpp
src/uri/fetchers/docker.cpp

Note: The commit hook requires separate commits for libprocess and mesos. That is why this is a separate review request.


Diffs
-----

  src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
  src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 
  src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 

Diff: https://reviews.apache.org/r/45660/diff/


Testing
-------

make check


Thanks,

Yong Tang