[GitHub] [flink] docete commented on issue #10208: [FLINK-11935][table-planner][table-planner-blink] Remove DateTimeUtils pull-in and fix datetime casting problem

[GitBox <gi...@apache.org>]

docete commented on issue #10208: [FLINK-11935][table-planner][table-planner-blink] Remove DateTimeUtils pull-in and fix datetime casting problem
URL: https://github.com/apache/flink/pull/10208#issuecomment-555296224
 
 
   > Do we have any existing tests to cover the changes in blink planner? For example, it should fail before that cast string to timestamp and date ceil.
   
   already exist.  
   date ceil case in ScalarFunctionsTest.testTemporalFloor.  Which we fixed in our copied `DateTimeUtils` in FLINK-13302. And should fix again since we removes it.
   
   for `cast string to timestamp`, it's a little tricky: the original string-> timestamp & timestamp -> string take account of Gregorian cutover and make case passed. No we ignore Gregorian cutover for both path. The case is TemporalTypesTest.testTimePointLiterals (`1500-04-30 12:00:00`)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services