You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Randy Kobes <ra...@theoryx5.uwinnipeg.ca> on 2004/06/21 07:33:11 UTC

[mp2] APR::Bucket w/o mod_perl

I believe the last APR::* module that depends on mod_perl.so
is APR::Bucket - this diff included modperl_bucket.c in the
files copiled into APR.so, so that APR::Bucket doesn't need
mod_perl.so:
====================================================
Index: Makefile.PL
===================================================================
RCS file: /home/cvs/modperl-2.0/xs/APR/APR/Makefile.PL,v
retrieving revision 1.20
diff -u -r1.20 Makefile.PL
--- Makefile.PL	16 Jun 2004 03:55:48 -0000	1.20
+++ Makefile.PL	21 Jun 2004 05:24:11 -0000
@@ -58,7 +58,7 @@

 # link the following into APR.so so other APR:: modules can be used
 # outside of httpd
-my @names = map { "modperl_$_" } (qw(error),
+my @names = map { "modperl_$_" } (qw(error bucket),
                                   map { "common_$_" } qw(util log));
 my(@obj, @clean, %src);
 for (@names) {

==================================================================

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] APR::Bucket w/o mod_perl

Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> On Tue, 22 Jun 2004, Stas Bekman wrote:
> 
> 
>>Randy Kobes wrote:
>>
>>>I believe the last APR::* module that depends on mod_perl.so
>>>is APR::Bucket - this diff included modperl_bucket.c in the
>>>files copiled into APR.so, so that APR::Bucket doesn't need
>>>mod_perl.so:
>>
>>+1
>>
>>I'm not sure this is the last one, since we don't test all APR:: modules.
> 
> 
> Thanks ... I used the term "last APR::*" module based simply
> on trying to compile all the APR::* modules without linking
> to mod_perl.so. But you're right - there may be dependencies
> on mod_perl.so lurking that testing will expose.

:)

>>Also I believe the copying part was originally a quick
>>hack, I see no reason why .c files should be compiled
>>twice. So eventually we should replace copy-n-compile with
>>create-right-dependecies-n-compile-once
> 
> 
> That's true ... What about, when building APR.so, simply
> linking in the relevant .o files within src/modules/perl
> (which already exist at this point of the build)?

That will work only if dependencies are made correctly, so you don't try to 
link against non-existing .o files. But things get complicated if you want to 
continue supporting make on SMP machines (make -j)

So you want to build src/modules/perl/*.c
then xs/APR/APR/APR.so
then mod_perl.so and the rest of xs/* in no particular order.

I forgot whether you still have this obstacle of needing to build APR.so 
before mod_perl.so, I think that's the case.

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] APR::Bucket w/o mod_perl

Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Tue, 22 Jun 2004, Stas Bekman wrote:

> Randy Kobes wrote:
> > I believe the last APR::* module that depends on mod_perl.so
> > is APR::Bucket - this diff included modperl_bucket.c in the
> > files copiled into APR.so, so that APR::Bucket doesn't need
> > mod_perl.so:
>
> +1
>
> I'm not sure this is the last one, since we don't test all APR:: modules.

Thanks ... I used the term "last APR::*" module based simply
on trying to compile all the APR::* modules without linking
to mod_perl.so. But you're right - there may be dependencies
on mod_perl.so lurking that testing will expose.

> Also I believe the copying part was originally a quick
> hack, I see no reason why .c files should be compiled
> twice. So eventually we should replace copy-n-compile with
> create-right-dependecies-n-compile-once

That's true ... What about, when building APR.so, simply
linking in the relevant .o files within src/modules/perl
(which already exist at this point of the build)?

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] APR::Bucket w/o mod_perl

Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> I believe the last APR::* module that depends on mod_perl.so
> is APR::Bucket - this diff included modperl_bucket.c in the
> files copiled into APR.so, so that APR::Bucket doesn't need
> mod_perl.so:

+1

I'm not sure this is the last one, since we don't test all APR:: modules.

Also I believe the copying part was originally a quick hack, I see no reason 
why .c files should be compiled twice. So eventually we should replace 
copy-n-compile with create-right-dependecies-n-compile-once

> ====================================================
> Index: Makefile.PL
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/xs/APR/APR/Makefile.PL,v
> retrieving revision 1.20
> diff -u -r1.20 Makefile.PL
> --- Makefile.PL	16 Jun 2004 03:55:48 -0000	1.20
> +++ Makefile.PL	21 Jun 2004 05:24:11 -0000
> @@ -58,7 +58,7 @@
> 
>  # link the following into APR.so so other APR:: modules can be used
>  # outside of httpd
> -my @names = map { "modperl_$_" } (qw(error),
> +my @names = map { "modperl_$_" } (qw(error bucket),
>                                    map { "common_$_" } qw(util log));
>  my(@obj, @clean, %src);
>  for (@names) {




-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org