[GitHub] [tvm] areusch commented on a change in pull request #7462: [Target] Add target host field for target specification

[GitBox <gi...@apache.org>]

areusch commented on a change in pull request #7462:
URL: https://github.com/apache/tvm/pull/7462#discussion_r578719962



##########
File path: python/tvm/target/target.py
##########
@@ -46,7 +46,7 @@ class Target(Object):
     - :py:func:`tvm.target.intel_graphics` create Intel Graphics target
     """
 
-    def __init__(self, tag_or_str_or_dict):
+    def __init__(self, tag_or_str_or_dict, host_tag_or_str_or_dict=None):

Review comment:
       for the API, I would almost expect `Target(target_host, sub_target_0, sub_target_1, ...)`
   
   what would be the future path towards supporting multiple sub-targets? would there be a target_host object which contains all the sub-targets?

##########
File path: include/tvm/target/target.h
##########
@@ -44,6 +44,8 @@ class TargetNode : public Object {
  public:
   /*! \brief The kind of the target device */
   TargetKind kind;
+  /*! \brief Target host information of the target device */
+  Optional<ObjectRef> host;

Review comment:
       could we reverse the order and forward-declare TargetNode?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org