You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "bamaer (via GitHub)" <gi...@apache.org> on 2023/02/23 12:13:14 UTC
[GitHub] [hop] bamaer opened a new pull request, #2460: added truncate table and truncate on first row options #2111
bamaer opened a new pull request, #2460:
URL: https://github.com/apache/hop/pull/2460
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #2460: added truncate table and truncate on first row options #2111
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on PR #2460:
URL: https://github.com/apache/hop/pull/2460#issuecomment-1441957969
Does this have sane defaults if it is an old transform XML?
Does it default to false then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] bamaer commented on pull request #2460: added truncate table and truncate on first row options #2111
Posted by "bamaer (via GitHub)" <gi...@apache.org>.
bamaer commented on PR #2460:
URL: https://github.com/apache/hop/pull/2460#issuecomment-1442156824
defaults to false if the option is not available in the pipeline.
verified in the GUI, existing XML is checked in the integration tests.
`integration-tests/vertica/0002-vertica-bulk-load.hpl` uses the older version of the transform.
`integration-tests/vertica/0003-vertica-bulk-load.hpl` repeats 0002 to check if the row count remains the same, i.e. the truncate worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva merged pull request #2460: added truncate table and truncate on first row options #2111
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva merged PR #2460:
URL: https://github.com/apache/hop/pull/2460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org