You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/04/23 23:06:54 UTC

[GitHub] [incubator-yunikorn-k8shim] avsamit6600 commented on pull request #256: [YUNIKORN-650] Retrieve user identity from predefined labels

avsamit6600 commented on pull request #256:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/256#issuecomment-825985527


   > hi @avsamit6600 the PR looks good. I left some minor comments.
   > Another thing, we may want to make this configurable via our charts, a configurable ENV var like [these lines](https://github.com/apache/incubator-yunikorn-release/blob/2ade62ac43f9f62f804739f418fcdcb256b9703b/helm-charts/yunikorn/templates/deployment.yaml#L56-L71), to provide easier overwritten.
   
   yeah that is how tested it as well. Works through charts. I will create another JIRA to add it to the release project. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org