[GitHub] [arrow] kiszk commented on a change in pull request #10201: ARROW-11776: [Java][Dataset] Support writing to files within dataset scanner via JNI

[GitBox <gi...@apache.org>]

kiszk commented on a change in pull request #10201:
URL: https://github.com/apache/arrow/pull/10201#discussion_r694165098



##########
File path: cpp/src/jni/dataset/jni_util.cc
##########
@@ -16,36 +16,44 @@
 // under the License.
 
 #include "jni/dataset/jni_util.h"
-
+#include "arrow/ipc/metadata_internal.h"
+#include "arrow/util/base64.h"
+#include "arrow/util/key_value_metadata.h"
 #include "arrow/util/logging.h"
 
+#include <memory>
 #include <mutex>
 
+#include <flatbuffers/flatbuffers.h>
+
 namespace arrow {
+
+namespace flatbuf = org::apache::arrow::flatbuf;
+
 namespace dataset {
 namespace jni {
 
 class ReservationListenableMemoryPool::Impl {
  public:
-  explicit Impl(arrow::MemoryPool* pool, std::shared_ptr<ReservationListener> listener,
+  explicit Impl(MemoryPool* pool, std::shared_ptr<ReservationListener> listener,
                 int64_t block_size)
       : pool_(pool),
         listener_(listener),
         block_size_(block_size),
         blocks_reserved_(0),
         bytes_reserved_(0) {}
 
-  arrow::Status Allocate(int64_t size, uint8_t** out) {

Review comment:
       I agree with @emkornfield. To split these types of changes into another PR make us easier to review this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org