You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nvazquez <gi...@git.apache.org> on 2017/01/20 18:30:11 UTC
[GitHub] cloudstack pull request #1913: CLOUDSTACK-9752: [Vmware] Optimization of vol...
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1913
CLOUDSTACK-9752: [Vmware] Optimization of volume attachness to vm
## Description
This optimization aims to reduce volume attach slowness due to vmdk files search on datastore before creating the volume (search for `.vmdk`, `-flat.vmdk` and `-delta.vmdk` files to delete them if they exist). This search is not necessary when attaching a volume in Allocated state, due to volume files don't exist on datastore.
On large datastores, this search can cause volume attachness to be really slow, as we can see in this log lines:
````
13-mgmt.log:2016-11-02 10:16:33,136 INFO [vmware.mo.DatastoreMO] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Searching file 9ce7731fd38b4045afbb7ce9754abbc1.vmdk in [b5ebda046d613e079b5874b169cd848f]
13-mgmt.log:2016-11-02 10:19:42,567 WARN [storage.resource.VmwareStorageLayoutHelper] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Unable to locate VMDK file: 9ce7731fd38b4045afbb7ce9754abbc1.vmdk
13-mgmt.log:2016-11-02 10:19:42,719 INFO [vmware.mo.DatastoreMO] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Search file 9ce7731fd38b4045afbb7ce9754abbc1-flat.vmdk on [b5ebda046d613e079b5874b169cd848f]
\u2026
13-mgmt.log:2016-11-02 10:19:44,399 INFO [vmware.mo.DatastoreMO] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Searching file 9ce7731fd38b4045afbb7ce9754abbc1-flat.vmdk in [b5ebda046d613e079b5874b169cd848f]
13-mgmt.log:2016-11-02 10:22:07,581 WARN [storage.resource.VmwareStorageLayoutHelper] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Unable to locate VMDK file: 9ce7731fd38b4045afbb7ce9754abbc1-flat.vmdk
13-mgmt.log:2016-11-02 10:22:07,731 INFO [vmware.mo.DatastoreMO] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Search file 9ce7731fd38b4045afbb7ce9754abbc1-delta.vmdk on [b5ebda046d613e079b5874b169cd848f]
13-mgmt.log:2016-11-02 10:22:09,745 INFO [vmware.mo.DatastoreMO] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Searching file 9ce7731fd38b4045afbb7ce9754abbc1-delta.vmdk in [b5ebda046d613e079b5874b169cd848f]
13-mgmt.log:2016-11-02 10:25:06,362 WARN [storage.resource.VmwareStorageLayoutHelper] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Unable to locate VMDK file: 9ce7731fd38b4045afbb7ce9754abbc1-delta.vmdk
````
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nvazquez/cloudstack createVolumeOptimization
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1913.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1913
----
commit 29308f0c53af1550b52bc0cb5a7558482c6da452
Author: nvazquez <ni...@gmail.com>
Date: 2017-01-20T16:20:37Z
CLOUDSTACK-9752: [Vmware] Optimization of volume attachness to vm
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1913: CLOUDSTACK-9752: [Vmware] Optimization of vol...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1913
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@blueorangutan test centos7 vmware-60u2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1913: CLOUDSTACK-9752: [Vmware] Optimization of vol...
Posted by syed <gi...@git.apache.org>.
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1913#discussion_r98365757
--- Diff: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java ---
@@ -1577,9 +1577,6 @@ public Answer createVolume(CreateObjectCommand cmd) {
}
synchronized (this) {
- // s_logger.info("Delete file if exists in datastore to clear the way for creating the volume. file: " + volumeDatastorePath);
- VmwareStorageLayoutHelper.deleteVolumeVmdkFiles(dsMo, volumeUuid.toString(), dcMo);
-
vmMo.createDisk(volumeDatastorePath, (int)(volume.getSize() / (1024L * 1024L)), morDatastore, vmMo.getScsiDeviceControllerKey());
vmMo.detachDisk(volumeDatastorePath, false);
--- End diff --
Is there a possibility that `detachDisk` might fail? In that case, we would require the above check to be performed as Cloudstack would retry the operation. Same in the `finally` clause
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@blueorangutan help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1913
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-491
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by SudharmaJain <gi...@git.apache.org>.
Github user SudharmaJain commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@nvazquez I think in case if connection to vcenter fails there are changes as the disk may get created on vcenter. In such case we may need to remove the vmdk. we can improve the logic to search vmdk in specific location of data store and reduce the delay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1913
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by serg38 <gi...@git.apache.org>.
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@karuturi This one is ready for merging. LGTM and test results are positive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by serg38 <gi...@git.apache.org>.
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@rhtyd @karuturi Can we run vmware tests on this PR and merge on success ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1913
<b>Trillian test result (tid-801)</b>
Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41486 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1913-t801-vmware-60u2.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 48 look ok, 1 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 801.37 | test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 330.63 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 146.22 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 516.19 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 316.12 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 675.68 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 578.48 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1466.72 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 682.28 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 614.37 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1265.89 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 20.66 | test_volumes.py
test_06_download_detached_volume | Success | 50.39 | test_volumes.py
test_05_detach_volume | Success | 100.24 | test_volumes.py
test_04_delete_attached_volume | Success | 10.15 | test_volumes.py
test_03_download_attached_volume | Success | 15.22 | test_volumes.py
test_02_attach_volume | Success | 54.95 | test_volumes.py
test_01_create_volume | Success | 434.99 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.17 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 188.95 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Success | 145.97 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 161.65 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 206.75 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.61 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.21 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 55.72 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.07 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 5.09 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 5.11 | test_vm_life_cycle.py
test_02_start_vm | Success | 15.15 | test_vm_life_cycle.py
test_01_stop_vm | Success | 5.09 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 191.28 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.03 | test_templates.py
test_05_template_permissions | Success | 0.16 | test_templates.py
test_04_extract_template | Success | 15.27 | test_templates.py
test_03_delete_template | Success | 5.08 | test_templates.py
test_02_edit_template | Success | 90.16 | test_templates.py
test_01_create_template | Success | 100.60 | test_templates.py
test_10_destroy_cpvm | Success | 226.34 | test_ssvm.py
test_09_destroy_ssvm | Success | 238.15 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.34 | test_ssvm.py
test_07_reboot_ssvm | Success | 158.08 | test_ssvm.py
test_06_stop_cpvm | Success | 176.54 | test_ssvm.py
test_05_stop_ssvm | Success | 173.23 | test_ssvm.py
test_04_cpvm_internals | Success | 1.01 | test_ssvm.py
test_03_ssvm_internals | Success | 3.13 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.09 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
test_01_snapshot_root_disk | Success | 21.01 | test_snapshots.py
test_04_change_offering_small | Success | 122.72 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
test_01_create_service_offering | Success | 0.08 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.09 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.12 | test_secondary_storage.py
test_09_reboot_router | Success | 120.69 | test_routers.py
test_08_start_router | Success | 95.50 | test_routers.py
test_07_stop_router | Success | 20.19 | test_routers.py
test_06_router_advanced | Success | 0.04 | test_routers.py
test_05_router_basic | Success | 0.03 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.52 | test_routers.py
test_03_restart_network_cleanup | Success | 110.68 | test_routers.py
test_02_router_internal_adv | Success | 0.90 | test_routers.py
test_01_router_internal_basic | Success | 0.44 | test_routers.py
test_router_dns_guestipquery | Success | 76.59 | test_router_dns.py
test_router_dns_externalipquery | Success | 0.04 | test_router_dns.py
test_router_dhcphosts | Success | 135.25 | test_router_dhcphosts.py
test_router_dhcp_opts | Success | 21.28 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.06 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 25.23 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.03 | test_regions.py
test_create_pvlan_network | Success | 5.14 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.29 | test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 925.39 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 600.80 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 171.94 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 35.90 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.14 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.32 | test_portable_publicip.py
test_isolate_network_password_server | Success | 97.87 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.09 | test_over_provisioning.py
test_oobm_zchange_password | Success | 30.51 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | Success | 16.27 | test_outofbandmanagement.py
test_oobm_issue_power_status | Success | 10.18 | test_outofbandmanagement.py
test_oobm_issue_power_soft | Success | 15.27 | test_outofbandmanagement.py
test_oobm_issue_power_reset | Success | 15.27 | test_outofbandmanagement.py
test_oobm_issue_power_on | Success | 15.26 | test_outofbandmanagement.py
test_oobm_issue_power_off | Success | 10.26 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | Success | 15.23 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | Success | 87.38 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | Success | 0.12 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | Success | 0.07 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | Success | 5.13 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | Success | 0.07 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | Success | 0.06 | test_outofbandmanagement.py
test_oobm_configure_default_driver | Success | 0.06 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | Success | 18.30 | test_outofbandmanagement.py
test_extendPhysicalNetworkVlan | Success | 15.25 | test_non_contigiousvlan.py
test_01_nic | Success | 479.31 | test_nic.py
test_releaseIP | Success | 302.32 | test_network.py
test_reboot_router | Success | 518.78 | test_network.py
test_public_ip_user_account | Success | 10.22 | test_network.py
test_public_ip_admin_account | Success | 40.22 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 71.40 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.34 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.50 | test_network.py
test_delete_account | Success | 251.87 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.47 | test_network.py
test_01_port_fwd_on_src_nat | Success | 111.81 | test_network.py
test_nested_virtualization_vmware | Success | 253.09 | test_nested_virtualization.py
test_nic_secondaryip_add_remove | Success | 202.04 | test_multipleips_per_nic.py
login_test_saml_user | Success | 17.84 | test_login.py
test_assign_and_removal_lb | Success | 133.35 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 187.01 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 202.68 | test_loadbalance.py
test_03_list_snapshots | Success | 0.08 | test_list_ids_parameter.py
test_02_list_templates | Success | 0.03 | test_list_ids_parameter.py
test_01_list_volumes | Success | 0.02 | test_list_ids_parameter.py
test_07_list_default_iso | Success | 0.04 | test_iso.py
test_05_iso_permissions | Success | 0.04 | test_iso.py
test_04_extract_Iso | Success | 5.21 | test_iso.py
test_03_delete_iso | Success | 95.14 | test_iso.py
test_02_edit_iso | Success | 0.11 | test_iso.py
test_01_create_iso | Success | 20.69 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 448.58 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 338.34 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 970.95 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 694.74 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.20 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.10 | test_global_settings.py
test_rolepermission_lifecycle_update | Success | 5.91 | test_dynamicroles.py
test_rolepermission_lifecycle_list | Success | 5.67 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | Success | 5.58 | test_dynamicroles.py
test_rolepermission_lifecycle_create | Success | 5.59 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | Success | 5.70 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | Success | 5.62 | test_dynamicroles.py
test_role_lifecycle_update | Success | 10.68 | test_dynamicroles.py
test_role_lifecycle_list | Success | 5.60 | test_dynamicroles.py
test_role_lifecycle_delete | Success | 10.63 | test_dynamicroles.py
test_role_lifecycle_create | Success | 5.60 | test_dynamicroles.py
test_role_inuse_deletion | Success | 5.59 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | Success | 7.02 | test_dynamicroles.py
test_role_account_acls | Success | 7.21 | test_dynamicroles.py
test_default_role_deletion | Success | 5.66 | test_dynamicroles.py
test_04_create_fat_type_disk_offering | Success | 0.05 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.03 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.04 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.05 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.07 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 40.51 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 65.64 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 171.19 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 20.36 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 131.06 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 5.69 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 5.58 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 5.66 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 212.02 | test_deploy_vm_iso.py
test_3d_gpu_support | Success | 443.92 | test_deploy_vgpu_enabled_vm.py
test_DeployVmAntiAffinityGroup | Success | 156.26 | test_affinity_groups.py
test_08_resize_volume | Skipped | 5.08 | test_volumes.py
test_07_resize_fail | Skipped | 10.22 | test_volumes.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
test_01_scale_vm | Skipped | 66.31 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.76 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@karuturi please package first
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by serg38 <gi...@git.apache.org>.
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1913
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@blueorangutan test centos7 vmware-60u2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1913
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-470
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1913
<b>Trillian test result (tid-831)</b>
Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44384 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1913-t831-vmware-60u2.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 48 look ok, 1 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 836.63 | test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 370.56 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 151.67 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 586.44 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 323.58 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 694.53 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 621.80 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1522.64 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 697.48 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 652.91 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1302.22 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 20.60 | test_volumes.py
test_06_download_detached_volume | Success | 45.64 | test_volumes.py
test_05_detach_volume | Success | 100.19 | test_volumes.py
test_04_delete_attached_volume | Success | 10.16 | test_volumes.py
test_03_download_attached_volume | Success | 15.23 | test_volumes.py
test_02_attach_volume | Success | 78.66 | test_volumes.py
test_01_create_volume | Success | 505.64 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.14 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 227.02 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Success | 201.38 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 161.76 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 262.23 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.76 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.21 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 61.03 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.10 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 5.11 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 5.11 | test_vm_life_cycle.py
test_02_start_vm | Success | 20.22 | test_vm_life_cycle.py
test_01_stop_vm | Success | 10.16 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 221.30 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.04 | test_templates.py
test_04_extract_template | Success | 10.24 | test_templates.py
test_03_delete_template | Success | 5.08 | test_templates.py
test_02_edit_template | Success | 90.16 | test_templates.py
test_01_create_template | Success | 110.89 | test_templates.py
test_10_destroy_cpvm | Success | 266.67 | test_ssvm.py
test_09_destroy_ssvm | Success | 238.32 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.38 | test_ssvm.py
test_07_reboot_ssvm | Success | 158.09 | test_ssvm.py
test_06_stop_cpvm | Success | 206.56 | test_ssvm.py
test_05_stop_ssvm | Success | 203.36 | test_ssvm.py
test_04_cpvm_internals | Success | 1.03 | test_ssvm.py
test_03_ssvm_internals | Success | 3.27 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.09 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.10 | test_ssvm.py
test_01_snapshot_root_disk | Success | 16.14 | test_snapshots.py
test_04_change_offering_small | Success | 116.78 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.09 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.12 | test_secondary_storage.py
test_09_reboot_router | Success | 175.84 | test_routers.py
test_08_start_router | Success | 115.81 | test_routers.py
test_07_stop_router | Success | 20.23 | test_routers.py
test_06_router_advanced | Success | 0.04 | test_routers.py
test_05_router_basic | Success | 0.03 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.53 | test_routers.py
test_03_restart_network_cleanup | Success | 145.89 | test_routers.py
test_02_router_internal_adv | Success | 0.87 | test_routers.py
test_01_router_internal_basic | Success | 0.46 | test_routers.py
test_router_dns_guestipquery | Success | 76.66 | test_router_dns.py
test_router_dns_externalipquery | Success | 0.06 | test_router_dns.py
test_router_dhcphosts | Success | 138.14 | test_router_dhcphosts.py
test_router_dhcp_opts | Success | 21.29 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.09 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 20.21 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.03 | test_regions.py
test_create_pvlan_network | Success | 5.16 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.30 | test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 1011.45 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 619.95 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 166.95 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 35.92 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.15 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.32 | test_portable_publicip.py
test_isolate_network_password_server | Success | 94.89 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.09 | test_over_provisioning.py
test_oobm_zchange_password | Success | 30.51 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | Success | 11.32 | test_outofbandmanagement.py
test_oobm_issue_power_status | Success | 10.19 | test_outofbandmanagement.py
test_oobm_issue_power_soft | Success | 15.25 | test_outofbandmanagement.py
test_oobm_issue_power_reset | Success | 15.26 | test_outofbandmanagement.py
test_oobm_issue_power_on | Success | 15.25 | test_outofbandmanagement.py
test_oobm_issue_power_off | Success | 15.23 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | Success | 15.25 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | Success | 87.19 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | Success | 5.11 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | Success | 0.07 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | Success | 5.14 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | Success | 0.07 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | Success | 0.06 | test_outofbandmanagement.py
test_oobm_configure_default_driver | Success | 0.06 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | Success | 23.32 | test_outofbandmanagement.py
test_extendPhysicalNetworkVlan | Success | 15.23 | test_non_contigiousvlan.py
test_01_nic | Success | 383.61 | test_nic.py
test_releaseIP | Success | 227.08 | test_network.py
test_reboot_router | Success | 568.81 | test_network.py
test_public_ip_user_account | Success | 10.22 | test_network.py
test_public_ip_admin_account | Success | 40.23 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 76.45 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.76 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 125.14 | test_network.py
test_delete_account | Success | 247.70 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.50 | test_network.py
test_01_port_fwd_on_src_nat | Success | 111.71 | test_network.py
test_nested_virtualization_vmware | Success | 288.01 | test_nested_virtualization.py
test_nic_secondaryip_add_remove | Success | 242.30 | test_multipleips_per_nic.py
login_test_saml_user | Success | 17.85 | test_login.py
test_assign_and_removal_lb | Success | 148.54 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 207.20 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 227.93 | test_loadbalance.py
test_03_list_snapshots | Success | 0.06 | test_list_ids_parameter.py
test_02_list_templates | Success | 0.06 | test_list_ids_parameter.py
test_01_list_volumes | Success | 0.02 | test_list_ids_parameter.py
test_07_list_default_iso | Success | 0.04 | test_iso.py
test_05_iso_permissions | Success | 0.10 | test_iso.py
test_04_extract_Iso | Success | 5.46 | test_iso.py
test_03_delete_iso | Success | 95.11 | test_iso.py
test_02_edit_iso | Success | 0.06 | test_iso.py
test_01_create_iso | Success | 20.71 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 494.87 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 373.19 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 932.06 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 757.12 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.19 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.10 | test_global_settings.py
test_rolepermission_lifecycle_update | Success | 5.79 | test_dynamicroles.py
test_rolepermission_lifecycle_list | Success | 5.67 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | Success | 5.81 | test_dynamicroles.py
test_rolepermission_lifecycle_create | Success | 5.60 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | Success | 5.67 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | Success | 5.61 | test_dynamicroles.py
test_role_lifecycle_update | Success | 10.65 | test_dynamicroles.py
test_role_lifecycle_list | Success | 5.68 | test_dynamicroles.py
test_role_lifecycle_delete | Success | 10.65 | test_dynamicroles.py
test_role_lifecycle_create | Success | 5.59 | test_dynamicroles.py
test_role_inuse_deletion | Success | 5.59 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | Success | 6.92 | test_dynamicroles.py
test_role_account_acls | Success | 7.05 | test_dynamicroles.py
test_default_role_deletion | Success | 5.64 | test_dynamicroles.py
test_04_create_fat_type_disk_offering | Success | 0.05 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.03 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.03 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.05 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.06 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 45.60 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 65.61 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 165.98 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 20.34 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 120.86 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 5.55 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 5.56 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 5.78 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 192.13 | test_deploy_vm_iso.py
test_3d_gpu_support | Success | 388.30 | test_deploy_vgpu_enabled_vm.py
test_DeployVmAntiAffinityGroup | Success | 186.34 | test_affinity_groups.py
test_08_resize_volume | Skipped | 5.09 | test_volumes.py
test_07_resize_fail | Skipped | 10.21 | test_volumes.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
test_01_scale_vm | Skipped | 66.37 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.72 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1913
LGTM. /cc @karuturi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@karuturi I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1']
Additional tests: list of comma separated tests with paths relative to the `test/integration` directory, for example: component/test_acl_listvm.py, component/test_volumes.py
Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'karuturi', 'abhinandanprateek', 'PaulAngus', 'borisstoyanov']
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@blueorangutan test centos7 vmware-60u2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@sateesh-chodapuneedi @SudharmaJain Can you provide your feedback? I think you guys worked on a similar fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1913: CLOUDSTACK-9752: [Vmware] Optimization of vol...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1913#discussion_r101452884
--- Diff: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java ---
@@ -1577,11 +1577,15 @@ public Answer createVolume(CreateObjectCommand cmd) {
}
synchronized (this) {
- // s_logger.info("Delete file if exists in datastore to clear the way for creating the volume. file: " + volumeDatastorePath);
- VmwareStorageLayoutHelper.deleteVolumeVmdkFiles(dsMo, volumeUuid.toString(), dcMo);
-
- vmMo.createDisk(volumeDatastorePath, (int)(volume.getSize() / (1024L * 1024L)), morDatastore, vmMo.getScsiDeviceControllerKey());
- vmMo.detachDisk(volumeDatastorePath, false);
+ try {
+ vmMo.createDisk(volumeDatastorePath, (int)(volume.getSize() / (1024L * 1024L)), morDatastore, vmMo.getScsiDeviceControllerKey());
+ vmMo.detachDisk(volumeDatastorePath, false);
+ }
+ catch (Exception e) {
+ s_logger.error("Deleting file " + volumeDatastorePath + " due to error: " + e.getMessage());
+ VmwareStorageLayoutHelper.deleteVolumeVmdkFiles(dsMo, volumeUuid.toString(), dcMo);
--- End diff --
This Looks good. Thanks for the update @nvazquez
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@karuturi a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1913: CLOUDSTACK-9752: [Vmware] Optimization of vol...
Posted by nvazquez <gi...@git.apache.org>.
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1913#discussion_r100543231
--- Diff: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java ---
@@ -1577,11 +1577,15 @@ public Answer createVolume(CreateObjectCommand cmd) {
}
synchronized (this) {
- // s_logger.info("Delete file if exists in datastore to clear the way for creating the volume. file: " + volumeDatastorePath);
- VmwareStorageLayoutHelper.deleteVolumeVmdkFiles(dsMo, volumeUuid.toString(), dcMo);
-
- vmMo.createDisk(volumeDatastorePath, (int)(volume.getSize() / (1024L * 1024L)), morDatastore, vmMo.getScsiDeviceControllerKey());
- vmMo.detachDisk(volumeDatastorePath, false);
+ try {
+ vmMo.createDisk(volumeDatastorePath, (int)(volume.getSize() / (1024L * 1024L)), morDatastore, vmMo.getScsiDeviceControllerKey());
+ vmMo.detachDisk(volumeDatastorePath, false);
+ }
+ catch (Exception e) {
+ s_logger.error("Deleting file " + volumeDatastorePath + " due to error: " + e.getMessage());
+ VmwareStorageLayoutHelper.deleteVolumeVmdkFiles(dsMo, volumeUuid.toString(), dcMo);
--- End diff --
Hi @syed @karuturi @SudharmaJain,
What do you think about this approach? We will delete vmdk file if either createDisk or detachDisk fails, this way we make sure file doesn't exist in case that CloudStack retries operation. By the way, in VolumeOrchestrator lines 556-588 there's the retry logic, to retry only if failure contains "request template reload":
````
for (int i = 0; i < 2; i++) {
// retry one more time in case of template reload is required for Vmware case
AsyncCallFuture<VolumeApiResult> future = null;
boolean isNotCreatedFromTemplate = volume.getTemplateId() == null ? true : false;
if (isNotCreatedFromTemplate) {
future = volService.createVolumeAsync(volume, store);
} else {
TemplateInfo templ = tmplFactory.getTemplate(template.getId(), DataStoreRole.Image);
future = volService.createVolumeFromTemplateAsync(volume, store.getId(), templ);
}
try {
VolumeApiResult result = future.get();
if (result.isFailed()) {
if (result.getResult().contains("request template reload") && (i == 0)) {
s_logger.debug("Retry template re-deploy for vmware");
continue;
} else {
s_logger.debug("create volume failed: " + result.getResult());
throw new CloudRuntimeException("create volume failed:" + result.getResult());
}
}
return result.getVolume();
} catch (InterruptedException e) {
s_logger.error("create volume failed", e);
throw new CloudRuntimeException("create volume failed", e);
} catch (ExecutionException e) {
s_logger.error("create volume failed", e);
throw new CloudRuntimeException("create volume failed", e);
}
}
throw new CloudRuntimeException("create volume failed even after template re-deploy");
}
````
To preserve this logic is that I've passed caught exception message on thrown exception in line 1587. Do you agree with this solution?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1913
@borisstoyanov @rhtyd @DaanHoogland Can you start vmware tests on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---