[GitHub] [airflow] dstandish commented on a change in pull request #11350: Allow execution of multiple sql statements in SnowflakeHook

[GitBox <gi...@apache.org>]

dstandish commented on a change in pull request #11350:
URL: https://github.com/apache/airflow/pull/11350#discussion_r582108801



##########
File path: airflow/providers/snowflake/hooks/snowflake.py
##########
@@ -142,3 +143,16 @@ def set_autocommit(self, conn, autocommit: Any) -> None:
 
     def get_autocommit(self, conn):
         return getattr(conn, 'autocommit_mode', False)
+
+    def run(self, sql, autocommit=False, parameters=None):
+        """
+        Snowflake-connector doesn't allow natively the execution of multiple SQL statements in the same
+        call. So for allowing to pass files or strings with several queries this method is coded,
+        that relies on run from DBApiHook
+        """
+        conn = self.get_conn()
+        self.set_autocommit(conn, autocommit)
+
+        queries = [item[0] for item in split_statements(StringIO(sql))]
+        for query in queries:
+            super().run(query, autocommit, parameters)

Review comment:
       the problem with this @JavierLopezT is it will reauthenticate for every statement.
   
   instead you should connect only once.  this way you can reuse temp tables, for example.  but also it will be faster




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org