You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/21 06:53:22 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
dongjoon-hyun opened a new pull request #31912:
URL: https://github.com/apache/spark/pull/31912
### What changes were proposed in this pull request?
Like we redact secrets and tokens, this PR aims to redact access key.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-803529137
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40883/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-803537340
**[Test build #136301 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136301/testReport)** for PR 31912 at commit [`2ee689a`](https://github.com/apache/spark/commit/2ee689a492a90392ca56c0f692e7b0e4590c32af).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-803660222
Thank you for review and approval, @viirya and @attilapiros .
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
attilapiros commented on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-803527402
> It could in some environments be considered sensitive data if you're looking to not release who accesses which systems and when, but it is not secret.
For me this means it is best to redact it by Spark.
As Spark might be running in such a environment where it is a sensitive data and there is no reason for us to release it and give it away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-803523958
Also, cc @attilapiros
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-803537592
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136301/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-803530475
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40883/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
attilapiros commented on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-803547654
Test failure (`org.apache.spark.deploy.SparkSubmitUtilsSuite.SPARK-34757: should ignore cache for SNAPSHOT dependencies`) is unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-803530462
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40883/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-803523879
cc @viirya since he is the release manager for Apache Spark 2.4.8 in addition to https://github.com/apache/spark/pull/23555 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] steveloughran commented on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
steveloughran commented on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-805767981
There's a config option hadoop.security.sensitive-config-keys which contains the patterns of keys to filter. If Spark used that then not only would it get the s3a stuff, it'd allow for per-site config to add more values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-803530475
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40883/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-807017343
Thank you, @steveloughran . However, this is used in Apache Spark UI to expose SparkConf values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-803660222
Thank you for review and approval, @viirya and @attilapiros .
Merged to master/3.1/3.0/2.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-803523451
**[Test build #136301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136301/testReport)** for PR 31912 at commit [`2ee689a`](https://github.com/apache/spark/commit/2ee689a492a90392ca56c0f692e7b0e4590c32af).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31912:
URL: https://github.com/apache/spark/pull/31912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-803537592
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136301/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31912: [SPARK-34811][CORE] Redact fs.s3a.access.key like secret and token
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31912:
URL: https://github.com/apache/spark/pull/31912#issuecomment-803523451
**[Test build #136301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136301/testReport)** for PR 31912 at commit [`2ee689a`](https://github.com/apache/spark/commit/2ee689a492a90392ca56c0f692e7b0e4590c32af).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org