You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Xinyu Liu <xi...@gmail.com> on 2016/09/29 18:24:28 UTC

Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52401/
-----------------------------------------------------------

Review request for samza and Navina Ramesh.


Repository: samza


Description
-------

Remove the deprecated the methods in kafka checkpoint classes.


Diffs
-----

  docs/contribute/coding-guide.md 6cb4cee6e182172e840e907c9e3ededddb7f4bc2 
  docs/learn/documentation/versioned/container/coordinator-stream.md b6805934189aff979165c8b5cc39320b8141f6cd 
  docs/learn/documentation/versioned/jobs/configuration-table.html 1d16f52c2530a5d4b6672f0718b53cd534564ee3 
  docs/learn/documentation/versioned/jobs/reprocessing.md 174b46ffcfdc5bd2cfdc5b451fc551ec451e7f1d 
  docs/learn/documentation/versioned/jobs/yarn-jobs.md d0e59918fc4f9303097d334a49ad1394196b6789 
  docs/learn/tutorials/versioned/remote-debugging-samza.md ad1d04d835f10aeb6996d2ecbee1d0ae65eb98e9 
  samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointLogKey.scala ea8462dc10d0c98fe99215e6b6b9d59cce4bcffa 
  samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala ea10cae82f2900c185c8c814f48dc02bbcb45621 
  samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TeskKafkaCheckpointLogKey.scala c360b6c74ff924311f350df2e49424351a5c8d07 

Diff: https://reviews.apache.org/r/52401/diff/


Testing
-------

./gradlew build


Thanks,

Xinyu Liu


Re: Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

Posted by Jagadish Venkatraman <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52401/#review150896
-----------------------------------------------------------


Ship it!




Ship It!

- Jagadish Venkatraman


On Sept. 29, 2016, 6:32 p.m., Xinyu Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52401/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2016, 6:32 p.m.)
> 
> 
> Review request for samza and Navina Ramesh.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Remove the deprecated yarn.container.count in docs
> 
> 
> Diffs
> -----
> 
>   docs/contribute/coding-guide.md 6cb4cee6e182172e840e907c9e3ededddb7f4bc2 
>   docs/learn/documentation/versioned/container/coordinator-stream.md b6805934189aff979165c8b5cc39320b8141f6cd 
>   docs/learn/documentation/versioned/jobs/configuration-table.html 1d16f52c2530a5d4b6672f0718b53cd534564ee3 
>   docs/learn/documentation/versioned/jobs/reprocessing.md 174b46ffcfdc5bd2cfdc5b451fc551ec451e7f1d 
>   docs/learn/documentation/versioned/jobs/yarn-jobs.md d0e59918fc4f9303097d334a49ad1394196b6789 
>   docs/learn/tutorials/versioned/remote-debugging-samza.md ad1d04d835f10aeb6996d2ecbee1d0ae65eb98e9 
> 
> Diff: https://reviews.apache.org/r/52401/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Xinyu Liu
> 
>


Re: Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

Posted by Xinyu Liu <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52401/
-----------------------------------------------------------

(Updated Sept. 29, 2016, 6:32 p.m.)


Review request for samza and Navina Ramesh.


Repository: samza


Description
-------

Remove the deprecated yarn.container.count in docs


Diffs (updated)
-----

  docs/contribute/coding-guide.md 6cb4cee6e182172e840e907c9e3ededddb7f4bc2 
  docs/learn/documentation/versioned/container/coordinator-stream.md b6805934189aff979165c8b5cc39320b8141f6cd 
  docs/learn/documentation/versioned/jobs/configuration-table.html 1d16f52c2530a5d4b6672f0718b53cd534564ee3 
  docs/learn/documentation/versioned/jobs/reprocessing.md 174b46ffcfdc5bd2cfdc5b451fc551ec451e7f1d 
  docs/learn/documentation/versioned/jobs/yarn-jobs.md d0e59918fc4f9303097d334a49ad1394196b6789 
  docs/learn/tutorials/versioned/remote-debugging-samza.md ad1d04d835f10aeb6996d2ecbee1d0ae65eb98e9 

Diff: https://reviews.apache.org/r/52401/diff/


Testing
-------


Thanks,

Xinyu Liu


Re: Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

Posted by Xinyu Liu <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52401/
-----------------------------------------------------------

(Updated Sept. 29, 2016, 6:31 p.m.)


Review request for samza and Navina Ramesh.


Repository: samza


Description (updated)
-------

Remove the deprecated yarn.container.count in docs


Diffs
-----

  samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointLogKey.scala ea8462dc10d0c98fe99215e6b6b9d59cce4bcffa 
  samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala ea10cae82f2900c185c8c814f48dc02bbcb45621 
  samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TeskKafkaCheckpointLogKey.scala c360b6c74ff924311f350df2e49424351a5c8d07 

Diff: https://reviews.apache.org/r/52401/diff/


Testing (updated)
-------


Thanks,

Xinyu Liu


Re: Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

Posted by Xinyu Liu <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52401/
-----------------------------------------------------------

(Updated Sept. 29, 2016, 6:26 p.m.)


Review request for samza and Navina Ramesh.


Repository: samza


Description
-------

Remove the deprecated the methods in kafka checkpoint classes.


Diffs (updated)
-----

  samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointLogKey.scala ea8462dc10d0c98fe99215e6b6b9d59cce4bcffa 
  samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala ea10cae82f2900c185c8c814f48dc02bbcb45621 
  samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TeskKafkaCheckpointLogKey.scala c360b6c74ff924311f350df2e49424351a5c8d07 

Diff: https://reviews.apache.org/r/52401/diff/


Testing
-------

./gradlew build


Thanks,

Xinyu Liu