You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2016/04/14 03:17:18 UTC
Re: Review Request 46185: Ranger SOLR plugins should not add dependent
libraries to component's CLASSPATH
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46185/
-----------------------------------------------------------
(Updated April 14, 2016, 1:17 a.m.)
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Repository: ranger
Description
-------
Ranger SOLR plugins should not add dependent libraries to component's CLASSPATH
Diffs
-----
agents-common/scripts/enable-agent.sh b9511d2
pom.xml 03815c1
ranger-solr-plugin-shim/.gitignore PRE-CREATION
ranger-solr-plugin-shim/pom.xml PRE-CREATION
ranger-solr-plugin-shim/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java PRE-CREATION
src/main/assembly/plugin-solr.xml 31ebd6b
Diff: https://reviews.apache.org/r/46185/diff/
Testing
-------
1) Untar the ranger_solr_plugin tar file.
2) modify install.properties as needed
3) enable solr plugin by running enable-solr-plugin.sh
4) verified solr dependency jar folder creation and shim folder creation
5) verified Ranger Classloader loading dependency jar.
6) verified Ranger Plugin authorizing and auditing solr operation.
Thanks,
Ramesh Mani
Re: Review Request 46185: Ranger SOLR plugins should not add dependent
libraries to component's CLASSPATH
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46185/#review128845
-----------------------------------------------------------
Fix it, then Ship it!
agents-common/scripts/enable-agent.sh (line 523)
<https://reviews.apache.org/r/46185/#comment192306>
Shouldn't this be "&&" - to make sure that the destination (file or directory) doesn't exist?
- Madhan Neethiraj
On April 14, 2016, 1:17 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46185/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 1:17 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger SOLR plugins should not add dependent libraries to component's CLASSPATH
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh b9511d2
> pom.xml 03815c1
> ranger-solr-plugin-shim/.gitignore PRE-CREATION
> ranger-solr-plugin-shim/pom.xml PRE-CREATION
> ranger-solr-plugin-shim/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java PRE-CREATION
> src/main/assembly/plugin-solr.xml 31ebd6b
>
> Diff: https://reviews.apache.org/r/46185/diff/
>
>
> Testing
> -------
>
> 1) Untar the ranger_solr_plugin tar file.
> 2) modify install.properties as needed
> 3) enable solr plugin by running enable-solr-plugin.sh
> 4) verified solr dependency jar folder creation and shim folder creation
> 5) verified Ranger Classloader loading dependency jar.
> 6) verified Ranger Plugin authorizing and auditing solr operation.
>
>
> Thanks,
>
> Ramesh Mani
>
>