You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/17 12:04:41 UTC
[GitHub] [arrow] jvanstraten opened a new pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
jvanstraten opened a new pull request #12448:
URL: https://github.com/apache/arrow/pull/12448
Modified Substrait consumer interaction with libprotobuf to support versions down to 3.0.0, which is the minimum required due to Substrait's usage of proto3 syntax.
Tested locally with:
```
export ARROW_PROTOBUF_URL=https://github.com/protocolbuffers/protobuf/releases/download/v3.0.0/protobuf-cpp-3.0.0.tar.gz
cmake \
--preset ninja-debug \
-DProtobuf_SOURCE=BUNDLED \
-DARROW_PROTOBUF_BUILD_VERSION=v3.0.0 \
-DARROW_PROTOBUF_BUILD_SHA256_CHECKSUM=318e8f375fb4e5333975a40e0d1215e855b4a8c581d692eb0eb7df70db1a8d4e
```
(Is there an easier way to do this without modifying versions.txt or 751fb9d7? Also, the env var is needed only because Google isn't at all consistent with their release file naming that far back.)
It'd also be nice to add this to CI, but it's probably excessive to always run for a PR, unless combined with some other run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jvanstraten commented on a change in pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
jvanstraten commented on a change in pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#discussion_r809292310
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -359,10 +359,19 @@ foreach(_VERSION_ENTRY ${TOOLCHAIN_VERSIONS_TXT})
continue()
endif()
- # For debugging
- message(STATUS "${_VARIABLE_NAME}: ${_VARIABLE_VALUE}")
+ # Allow values to be overridden to test specific versions during development
Review comment:
Reverted here: f3b23a05
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#issuecomment-1043277833
Revision: f3b23a055694288ea73cbd77bafaa68855f69dc6
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1650](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1650)
|Task|Status|
|----|------|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1650-github-test-build-cpp-fuzz)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1650-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1650-azure-test-conda-cpp-valgrind)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1650-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1650-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1650-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1650-github-test-debian-11-cpp-i386)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1650-github-test-fedora-33-cpp)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1650-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1650-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1650-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1650-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1650-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1650-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1650-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1650-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-21.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1650-github-test-ubuntu-21.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jvanstraten commented on pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
jvanstraten commented on pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#issuecomment-1043208924
Presumably 2144b75 will solve the above, but I wasn't able to reproduce the problem locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jvanstraten commented on a change in pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
jvanstraten commented on a change in pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#discussion_r809089219
##########
File path: cpp/src/arrow/engine/substrait/expression_internal.cc
##########
@@ -443,8 +443,11 @@ struct ScalarToProtoImpl {
return Status::OK();
}
+ // Note: while std::string&& would be better for the argument
+ // type, older versions of protobuf don't have this overload
+ // yet.
template <typename ScalarWithBufferValue>
- Status FromBuffer(void (substrait::Expression::Literal::*set)(std::string&&),
+ Status FromBuffer(void (substrait::Expression::Literal::*set)(const std::string&),
Review comment:
That yields some positively ugly code IMO, but here it is: 7ffd90f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#issuecomment-1043116391
Revision: 7ffd90f08ab06c3462db55507d8a560fa4c60ba9
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1647](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1647)
|Task|Status|
|----|------|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1647-github-test-build-cpp-fuzz)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1647-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1647-azure-test-conda-cpp-valgrind)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1647-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1647-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1647-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1647-github-test-debian-11-cpp-i386)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1647-github-test-fedora-33-cpp)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1647-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1647-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1647-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1647-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1647-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1647-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1647-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1647-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-21.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1647-github-test-ubuntu-21.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jvanstraten commented on pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
jvanstraten commented on pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#issuecomment-1043174356
```
[ 22%] Generating generated/substrait/capabilities.pb.h
/build/cpp/src/arrow/engine/generated/: No such file or directory
make[2]: *** [src/arrow/engine/CMakeFiles/substrait_gen.dir/build.make:78: src/arrow/engine/generated/substrait/capabilities.pb.h] Error 1
```
https://github.com/ursacomputing/crossbow/runs/5234942880?check_suite_focus=true
That's a new one... Looking at it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#issuecomment-1043476658
Benchmark runs are scheduled for baseline = faef18b43b868c2fb6076d433920909b514db3e7 and contender = 7d16a78d8632b1e7374a7c8b6f762854eb56f9d5. 7d16a78d8632b1e7374a7c8b6f762854eb56f9d5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/90ee270ebc3447a68bd203d9e09b6ca1...d6ab854da4834d17bd65465e897337a6/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/21bbca92d8114e208379fa9b196d7a23...458d152eba04451681452d0ab2e5a474/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/11d51c96289b4030893264ead2a8a407...de459e6383fb42b5afc6e48d85ec09d6/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8b0c699b9a4548d28a2b6c9dc55f3310...3b50f449bcc74d009d388b9b7b576e08/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#discussion_r809204651
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -359,10 +359,19 @@ foreach(_VERSION_ENTRY ${TOOLCHAIN_VERSIONS_TXT})
continue()
endif()
- # For debugging
- message(STATUS "${_VARIABLE_NAME}: ${_VARIABLE_VALUE}")
+ # Allow values to be overridden to test specific versions during development
Review comment:
Which protobuf version is in 18.04? That is exercised in nightly builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#issuecomment-1043476658
Benchmark runs are scheduled for baseline = faef18b43b868c2fb6076d433920909b514db3e7 and contender = 7d16a78d8632b1e7374a7c8b6f762854eb56f9d5. 7d16a78d8632b1e7374a7c8b6f762854eb56f9d5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/90ee270ebc3447a68bd203d9e09b6ca1...d6ab854da4834d17bd65465e897337a6/)
[Finished :arrow_down:0.68% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/21bbca92d8114e208379fa9b196d7a23...458d152eba04451681452d0ab2e5a474/)
[Failed :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/11d51c96289b4030893264ead2a8a407...de459e6383fb42b5afc6e48d85ec09d6/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8b0c699b9a4548d28a2b6c9dc55f3310...3b50f449bcc74d009d388b9b7b576e08/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#issuecomment-1042880248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#issuecomment-1043113376
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#discussion_r809101654
##########
File path: cpp/src/arrow/engine/substrait/expression_internal.cc
##########
@@ -443,8 +443,11 @@ struct ScalarToProtoImpl {
return Status::OK();
}
+ // Note: while std::string&& would be better for the argument
+ // type, older versions of protobuf don't have this overload
+ // yet.
template <typename ScalarWithBufferValue>
- Status FromBuffer(void (substrait::Expression::Literal::*set)(std::string&&),
+ Status FromBuffer(void (substrait::Expression::Literal::*set)(const std::string&),
Review comment:
If the lambda is too ugly, we can also remove the `FromBuffer` helpers, which will add at most one line of code to each caller. In both cases the bottom line is that we don't hardcode the actual protobuf method signature, so we're more robust against signature changes.
##########
File path: cpp/src/arrow/engine/substrait/expression_internal.cc
##########
@@ -443,8 +443,11 @@ struct ScalarToProtoImpl {
return Status::OK();
}
+ // Note: while std::string&& would be better for the argument
+ // type, older versions of protobuf don't have this overload
+ // yet.
template <typename ScalarWithBufferValue>
- Status FromBuffer(void (substrait::Expression::Literal::*set)(std::string&&),
+ Status FromBuffer(void (substrait::Expression::Literal::*set)(const std::string&),
Review comment:
If the lambda is too ugly, we can also remove the `FromBuffer` helper, which will add at most one line of code to each caller. In both cases the bottom line is that we don't hardcode the actual protobuf method signature, so we're more robust against signature changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#discussion_r809482044
##########
File path: cpp/src/arrow/engine/CMakeLists.txt
##########
@@ -66,6 +66,8 @@ if(MSVC)
list(APPEND SUBSTRAIT_SUPPRESSED_WARNINGS "/wd4251")
endif()
+file(MAKE_DIRECTORY "${SUBSTRAIT_GEN_DIR}/substrait")
Review comment:
CMake is sometimes finicky with non-existing directories, so I'm not surprised.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jvanstraten commented on a change in pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
jvanstraten commented on a change in pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#discussion_r809474592
##########
File path: cpp/src/arrow/engine/CMakeLists.txt
##########
@@ -66,6 +66,8 @@ if(MSVC)
list(APPEND SUBSTRAIT_SUPPRESSED_WARNINGS "/wd4251")
endif()
+file(MAKE_DIRECTORY "${SUBSTRAIT_GEN_DIR}/substrait")
Review comment:
I'm not sure, to be honest. See failing crossbox build above, which I wasn't able to reproduce. I figured it can't hurt to explicitly create the directory, so why not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jvanstraten commented on a change in pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
jvanstraten commented on a change in pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#discussion_r809245700
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -359,10 +359,19 @@ foreach(_VERSION_ENTRY ${TOOLCHAIN_VERSIONS_TXT})
continue()
endif()
- # For debugging
- message(STATUS "${_VARIABLE_NAME}: ${_VARIABLE_VALUE}")
+ # Allow values to be overridden to test specific versions during development
Review comment:
Huh, I thought I looked at this earlier and it was 3.12 or something, but I must have misread, because it's actually 3.0.0. So that's easy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#issuecomment-1043476658
Benchmark runs are scheduled for baseline = faef18b43b868c2fb6076d433920909b514db3e7 and contender = 7d16a78d8632b1e7374a7c8b6f762854eb56f9d5. 7d16a78d8632b1e7374a7c8b6f762854eb56f9d5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/90ee270ebc3447a68bd203d9e09b6ca1...d6ab854da4834d17bd65465e897337a6/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/21bbca92d8114e208379fa9b196d7a23...458d152eba04451681452d0ab2e5a474/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/11d51c96289b4030893264ead2a8a407...de459e6383fb42b5afc6e48d85ec09d6/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8b0c699b9a4548d28a2b6c9dc55f3310...3b50f449bcc74d009d388b9b7b576e08/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace closed pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
westonpace closed pull request #12448:
URL: https://github.com/apache/arrow/pull/12448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#issuecomment-1043476658
Benchmark runs are scheduled for baseline = faef18b43b868c2fb6076d433920909b514db3e7 and contender = 7d16a78d8632b1e7374a7c8b6f762854eb56f9d5. 7d16a78d8632b1e7374a7c8b6f762854eb56f9d5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/90ee270ebc3447a68bd203d9e09b6ca1...d6ab854da4834d17bd65465e897337a6/)
[Finished :arrow_down:0.68% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/21bbca92d8114e208379fa9b196d7a23...458d152eba04451681452d0ab2e5a474/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/11d51c96289b4030893264ead2a8a407...de459e6383fb42b5afc6e48d85ec09d6/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8b0c699b9a4548d28a2b6c9dc55f3310...3b50f449bcc74d009d388b9b7b576e08/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#discussion_r809574416
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -359,10 +359,19 @@ foreach(_VERSION_ENTRY ${TOOLCHAIN_VERSIONS_TXT})
continue()
endif()
- # For debugging
- message(STATUS "${_VARIABLE_NAME}: ${_VARIABLE_VALUE}")
+ # Allow values to be overridden to test specific versions during development
Review comment:
This feature will be useful when when we use custom `ARROW_XXX_URL` environment variable to use other version.
But mixing environment variables and CMake variables confuses us. So another approach may be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#discussion_r808997942
##########
File path: cpp/src/arrow/engine/substrait/expression_internal.cc
##########
@@ -443,8 +443,11 @@ struct ScalarToProtoImpl {
return Status::OK();
}
+ // Note: while std::string&& would be better for the argument
+ // type, older versions of protobuf don't have this overload
+ // yet.
template <typename ScalarWithBufferValue>
- Status FromBuffer(void (substrait::Expression::Literal::*set)(std::string&&),
+ Status FromBuffer(void (substrait::Expression::Literal::*set)(const std::string&),
Review comment:
You could also take a lambda and let C++ resolve the best overload there:
```c++
template <typename LitteralSetter>
Status FromBuffer(LitteralSetter&& set_lit,
const ScalarWithBufferValue& scalar_with_buffer) {
set_lit(lit_, scalar_with_buffer.value->ToString());
return Status::OK();
}
Status Visit(const StringScalar& s) {
return FromBuffer([](Lit* lit, std::string s) { lit->set_string(std::move(s)); });
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jvanstraten commented on pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
jvanstraten commented on pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#issuecomment-1043275984
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#issuecomment-1043476658
Benchmark runs are scheduled for baseline = faef18b43b868c2fb6076d433920909b514db3e7 and contender = 7d16a78d8632b1e7374a7c8b6f762854eb56f9d5. 7d16a78d8632b1e7374a7c8b6f762854eb56f9d5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/90ee270ebc3447a68bd203d9e09b6ca1...d6ab854da4834d17bd65465e897337a6/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/21bbca92d8114e208379fa9b196d7a23...458d152eba04451681452d0ab2e5a474/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/11d51c96289b4030893264ead2a8a407...de459e6383fb42b5afc6e48d85ec09d6/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8b0c699b9a4548d28a2b6c9dc55f3310...3b50f449bcc74d009d388b9b7b576e08/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#issuecomment-1043476658
Benchmark runs are scheduled for baseline = faef18b43b868c2fb6076d433920909b514db3e7 and contender = 7d16a78d8632b1e7374a7c8b6f762854eb56f9d5. 7d16a78d8632b1e7374a7c8b6f762854eb56f9d5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/90ee270ebc3447a68bd203d9e09b6ca1...d6ab854da4834d17bd65465e897337a6/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/21bbca92d8114e208379fa9b196d7a23...458d152eba04451681452d0ab2e5a474/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/11d51c96289b4030893264ead2a8a407...de459e6383fb42b5afc6e48d85ec09d6/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8b0c699b9a4548d28a2b6c9dc55f3310...3b50f449bcc74d009d388b9b7b576e08/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jvanstraten commented on a change in pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
jvanstraten commented on a change in pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#discussion_r809161535
##########
File path: cpp/src/arrow/engine/substrait/expression_internal.cc
##########
@@ -443,8 +443,11 @@ struct ScalarToProtoImpl {
return Status::OK();
}
+ // Note: while std::string&& would be better for the argument
+ // type, older versions of protobuf don't have this overload
+ // yet.
template <typename ScalarWithBufferValue>
- Status FromBuffer(void (substrait::Expression::Literal::*set)(std::string&&),
+ Status FromBuffer(void (substrait::Expression::Literal::*set)(const std::string&),
Review comment:
It's fine, for now anyway. IMO it's more important that builds start working on master again. If it gets annoying it can be cleaned up later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#issuecomment-1043476658
Benchmark runs are scheduled for baseline = faef18b43b868c2fb6076d433920909b514db3e7 and contender = 7d16a78d8632b1e7374a7c8b6f762854eb56f9d5. 7d16a78d8632b1e7374a7c8b6f762854eb56f9d5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/90ee270ebc3447a68bd203d9e09b6ca1...d6ab854da4834d17bd65465e897337a6/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/21bbca92d8114e208379fa9b196d7a23...458d152eba04451681452d0ab2e5a474/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/11d51c96289b4030893264ead2a8a407...de459e6383fb42b5afc6e48d85ec09d6/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8b0c699b9a4548d28a2b6c9dc55f3310...3b50f449bcc74d009d388b9b7b576e08/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#discussion_r809176053
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -359,10 +359,19 @@ foreach(_VERSION_ENTRY ${TOOLCHAIN_VERSIONS_TXT})
continue()
endif()
- # For debugging
- message(STATUS "${_VARIABLE_NAME}: ${_VARIABLE_VALUE}")
+ # Allow values to be overridden to test specific versions during development
Review comment:
Do we really want to keep this snippet? Also @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jvanstraten commented on a change in pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
jvanstraten commented on a change in pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#discussion_r809201954
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -359,10 +359,19 @@ foreach(_VERSION_ENTRY ${TOOLCHAIN_VERSIONS_TXT})
continue()
endif()
- # For debugging
- message(STATUS "${_VARIABLE_NAME}: ${_VARIABLE_VALUE}")
+ # Allow values to be overridden to test specific versions during development
Review comment:
It doesn't really belong in this PR, so I'm fine with removing it, but it does make it harder to verify compatibility with 3.0.0 for future changes manually or using CI (assuming there is not already a better way for overriding versions.txt).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a change in pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04
Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#discussion_r809350651
##########
File path: cpp/src/arrow/engine/CMakeLists.txt
##########
@@ -66,6 +66,8 @@ if(MSVC)
list(APPEND SUBSTRAIT_SUPPRESSED_WARNINGS "/wd4251")
endif()
+file(MAKE_DIRECTORY "${SUBSTRAIT_GEN_DIR}/substrait")
Review comment:
Why is this needed? Did the older version of protoc not create the output directory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org