You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2016/09/27 12:14:44 UTC

[kudu-CR] KUDU-1653 - [python] Python 3 Failing to Deserialize Token 

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4542

Change subject: KUDU-1653 - [python] Python 3 Failing to Deserialize Token
......................................................................

KUDU-1653 - [python] Python 3 Failing to Deserialize Token

Python 3 is failing to deserialize tokens because it is forcing it
to decode in UTF-8.  The serialized tokens should be left as byte
strings to avoid this issue. This patch is tested by existing tests.

Change-Id: I1969d67fa75db28626e0d4e130f1d68a5fd3b1d5
---
M python/kudu/client.pyx
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/4542/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1969d67fa75db28626e0d4e130f1d68a5fd3b1d5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>

[kudu-CR] KUDU-1653 - [python] Python 3 Failing to Deserialize Token

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: KUDU-1653 - [python] Python 3 Failing to Deserialize Token
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1969d67fa75db28626e0d4e130f1d68a5fd3b1d5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] KUDU-1653 - [python] Python 3 Failing to Deserialize Token

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: KUDU-1653 - [python] Python 3 Failing to Deserialize Token
......................................................................


KUDU-1653 - [python] Python 3 Failing to Deserialize Token

Python 3 is failing to deserialize tokens because it is forcing it
to decode in UTF-8.  The serialized tokens should be left as byte
strings to avoid this issue. This patch is tested by existing tests.

Change-Id: I1969d67fa75db28626e0d4e130f1d68a5fd3b1d5
Reviewed-on: http://gerrit.cloudera.org:8080/4542
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M python/kudu/client.pyx
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1969d67fa75db28626e0d4e130f1d68a5fd3b1d5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>