You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sadpandajoe (via GitHub)" <gi...@apache.org> on 2026/08/18 23:22:59 UTC
[PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
sadpandajoe opened a new pull request, #43314:
URL: https://github.com/apache/superset/pull/43314
### SUMMARY
When a Time-Series chart's Legend Type is set to Plain (List) and enough grouped
dimensions are combined to produce many legend entries, the legend can render on
top of the chart's plot area instead of the chart displaying properly. The chart's
own legend-layout estimator already computed how much vertical/horizontal margin a
Plain legend actually needs, but that computed margin was clamped to a fixed
fraction of the chart's height/width — a legend with more entries than the clamp
allowed still rendered every row (nothing paginates or hides a Plain legend's
entries), so entries beyond the clamped margin painted over the plot grid.
This change makes the Timeseries chart reserve the full margin its own estimator
computes, bounded only by a small fixed minimum plot space so the chart area is
never fully consumed, and correctly accounts for the other fixed grid padding
(top offset, zoomable bottom/left padding, axis-title offsets) so the reserved
space matches what ECharts actually lays out. It does not change how the legend
type itself is resolved — an explicit Plain/List selection is still always
honored, never silently switched to a scrolling legend. The change is scoped to
the Timeseries chart plugin; the shared legend-layout helper's behavior for other
chart types (Mixed Timeseries, Gantt, Pie, Funnel, Radar, Bubble, Graph) is
unchanged.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
_Attached separately after live verification._
### TESTING INSTRUCTIONS
1. Create a Time-Series Line Chart using a dataset with two grouped dimensions
whose combination produces many series (dozens or more) — e.g. two categorical
columns with a handful of distinct values each.
2. Under the Customize tab, set Legend Type to Plain and Legend Orientation to Top
(the default).
3. Create/update the chart.
4. Verify the legend no longer overlaps the chart's plot area — the plot area
shrinks to make room for the full legend instead.
5. Verify a chart with only a few legend entries is unaffected (legend still
reserves only the minimal padding it needs).
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5420676549
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/32930948305) for [7ad3202](https://github.com/apache/superset/commit/7ad3202)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5446329573
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/33125454356) for [5f195cf](https://github.com/apache/superset/commit/5f195cf)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5335436357
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): render Plain Timeseries legends as HTML, not canvas [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe merged PR #43314:
URL: https://github.com/apache/superset/pull/43314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): render Plain Timeseries legends as HTML, not canvas [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #43314:
URL: https://github.com/apache/superset/pull/43314#discussion_r3919434901
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/TimeseriesLegend.tsx:
##########
@@ -0,0 +1,192 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { memo } from 'react';
+import { styled } from '@apache-superset/core/theme';
+import { t } from '@apache-superset/core/translation';
+import type { TimeseriesCustomLegend } from './types';
+
+const LegendViewport = styled.div<{ maxHeight: number }>`
+ ${({ maxHeight, theme }) => `
+ box-sizing: border-box;
+ color: ${theme.colorText};
+ font-size: ${theme.fontSizeSM}px;
+ max-height: ${maxHeight}px;
+ overflow-x: hidden;
+ overflow-y: auto;
+ padding: ${theme.sizeUnit}px ${theme.sizeUnit * 2}px;
+ width: 100%;
+ `}
+`;
+
+const SelectorRow = styled.div`
+ ${({ theme }) => `
+ align-items: center;
+ background: ${theme.colorBgContainer};
+ display: flex;
+ gap: ${theme.sizeUnit}px;
+ justify-content: flex-end;
+ padding-bottom: ${theme.sizeUnit}px;
+ position: sticky;
+ top: 0;
+ z-index: 1;
+ `}
+`;
+
+const SelectorButton = styled.button`
+ ${({ theme }) => `
+ background: transparent;
+ border: 1px solid ${theme.colorBorder};
+ border-radius: ${theme.borderRadius}px;
+ color: ${theme.colorText};
+ cursor: pointer;
+ font: inherit;
+ padding: 0 ${theme.sizeUnit}px;
+
+ &:hover {
+ color: ${theme.colorPrimary};
+ }
+ `}
+`;
+
+const ItemList = styled.ul`
+ ${({ theme }) => `
+ align-items: flex-start;
+ display: flex;
+ flex-wrap: wrap;
+ gap: ${theme.sizeUnit * 2}px;
+ list-style: none;
+ margin: 0;
+ padding: 0;
+ `}
+`;
+
+const LegendItem = styled.li`
+ min-width: 0;
+`;
+
+const ItemButton = styled.button<{ selected: boolean }>`
+ ${({ selected, theme }) => `
+ align-items: flex-start;
+ appearance: none;
+ background: none;
+ border: none;
+ color: ${selected ? theme.colorText : theme.colorTextDisabled};
+ cursor: pointer;
+ display: inline-flex;
+ font: inherit;
+ gap: ${theme.sizeUnit}px;
+ max-width: 100%;
+ padding: 0;
+ text-align: left;
+
+ &:disabled {
+ cursor: default;
+ }
+ `}
+`;
+
+const Swatch = styled.span<{ color: string; selected: boolean }>`
+ ${({ color, selected }) => `
+ background: ${selected ? color : 'transparent'};
+ border: 1px solid ${color};
+ box-sizing: border-box;
+ flex: 0 0 auto;
+ height: 12px;
+ margin-top: 2px;
+ width: 12px;
+ `}
+`;
+
+const Label = styled.span`
+ overflow-wrap: anywhere;
+ white-space: pre-line;
+`;
+
+const RowBreak = styled.li`
+ flex-basis: 100%;
+ height: 0;
+`;
+
+export type TimeseriesLegendProps = TimeseriesCustomLegend & {
+ maxHeight: number;
+ onAll: () => void;
+ onInverse: () => void;
+ onToggle: (name: string) => void;
+};
+
+function TimeseriesLegend({
+ items,
+ maxHeight,
+ onAll,
+ onInverse,
+ onToggle,
+ showSelectors,
+}: TimeseriesLegendProps) {
+ if (items.length === 0 || maxHeight <= 0) {
+ return null;
+ }
+
+ return (
+ <LegendViewport data-test="timeseries-custom-legend" maxHeight={maxHeight}>
+ {showSelectors && (
+ <SelectorRow>
+ <SelectorButton type="button" onClick={onAll}>
+ {t('All')}
+ </SelectorButton>
+ <SelectorButton type="button" onClick={onInverse}>
+ {t('Inverse')}
+ </SelectorButton>
+ </SelectorRow>
+ )}
+ <ItemList>
+ {items.map((item, index) =>
+ item.name === '' || item.name === '\n' ? (
+ <RowBreak
+ // ECharts treats these exact values as row-break sentinels.
+ key={`row-break-${item.name}-${index}`}
+ />
+ ) : (
+ <LegendItem key={item.name}>
+ <ItemButton
Review Comment:
Good catch, added in f60e348. `TimeseriesLegend` now wires `onMouseEnter`/`onMouseLeave` to `onHover`, and `EchartsTimeseries` dispatches `highlight`/`downplay` by `seriesName` through the existing `dispatchLegendAction`, so hovering an HTML legend item now emphasizes its series the same way the native legend did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5444623093
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/33111103848) for [6965baf](https://github.com/apache/superset/commit/6965baf)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5444795955
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/33111103848) for [6965baf](https://github.com/apache/superset/commit/6965baf)
• **Environment:** http://54.213.84.123:8080 (admin/admin)
• **Lifetime:** 48h auto-cleanup
• **Updates:** New commits create fresh environments automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5360961384
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/32411178692) for [f0f7e12](https://github.com/apache/superset/commit/f0f7e12)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5362487521
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/32413737054) for [5c0717f](https://github.com/apache/superset/commit/5c0717f)
• **Environment:** http://52.13.56.238:8080 (admin/admin)
• **Lifetime:** 48h auto-cleanup
• **Updates:** New commits create fresh environments automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5420915667
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/32932218668) for [9b8da16](https://github.com/apache/superset/commit/9b8da16)
• **Environment:** http://44.243.198.58:8080 (admin/admin)
• **Lifetime:** 48h auto-cleanup
• **Updates:** New commits create fresh environments automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5362277603
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/32413737054) for [5c0717f](https://github.com/apache/superset/commit/5c0717f)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): render Plain Timeseries legends as HTML, not canvas [superset]
Posted by "gabotorresruiz (via GitHub)" <gi...@apache.org>.
gabotorresruiz commented on code in PR #43314:
URL: https://github.com/apache/superset/pull/43314#discussion_r3917975465
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/TimeseriesLegend.tsx:
##########
@@ -0,0 +1,192 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { memo } from 'react';
+import { styled } from '@apache-superset/core/theme';
+import { t } from '@apache-superset/core/translation';
+import type { TimeseriesCustomLegend } from './types';
+
+const LegendViewport = styled.div<{ maxHeight: number }>`
+ ${({ maxHeight, theme }) => `
+ box-sizing: border-box;
+ color: ${theme.colorText};
+ font-size: ${theme.fontSizeSM}px;
+ max-height: ${maxHeight}px;
+ overflow-x: hidden;
+ overflow-y: auto;
+ padding: ${theme.sizeUnit}px ${theme.sizeUnit * 2}px;
+ width: 100%;
+ `}
+`;
+
+const SelectorRow = styled.div`
+ ${({ theme }) => `
+ align-items: center;
+ background: ${theme.colorBgContainer};
+ display: flex;
+ gap: ${theme.sizeUnit}px;
+ justify-content: flex-end;
+ padding-bottom: ${theme.sizeUnit}px;
+ position: sticky;
+ top: 0;
+ z-index: 1;
+ `}
+`;
+
+const SelectorButton = styled.button`
+ ${({ theme }) => `
+ background: transparent;
+ border: 1px solid ${theme.colorBorder};
+ border-radius: ${theme.borderRadius}px;
+ color: ${theme.colorText};
+ cursor: pointer;
+ font: inherit;
+ padding: 0 ${theme.sizeUnit}px;
+
+ &:hover {
+ color: ${theme.colorPrimary};
+ }
+ `}
+`;
+
+const ItemList = styled.ul`
+ ${({ theme }) => `
+ align-items: flex-start;
+ display: flex;
+ flex-wrap: wrap;
+ gap: ${theme.sizeUnit * 2}px;
+ list-style: none;
+ margin: 0;
+ padding: 0;
+ `}
+`;
+
+const LegendItem = styled.li`
+ min-width: 0;
+`;
+
+const ItemButton = styled.button<{ selected: boolean }>`
+ ${({ selected, theme }) => `
+ align-items: flex-start;
+ appearance: none;
+ background: none;
+ border: none;
+ color: ${selected ? theme.colorText : theme.colorTextDisabled};
+ cursor: pointer;
+ display: inline-flex;
+ font: inherit;
+ gap: ${theme.sizeUnit}px;
+ max-width: 100%;
+ padding: 0;
+ text-align: left;
+
+ &:disabled {
+ cursor: default;
+ }
+ `}
+`;
+
+const Swatch = styled.span<{ color: string; selected: boolean }>`
+ ${({ color, selected }) => `
+ background: ${selected ? color : 'transparent'};
+ border: 1px solid ${color};
+ box-sizing: border-box;
+ flex: 0 0 auto;
+ height: 12px;
+ margin-top: 2px;
+ width: 12px;
+ `}
+`;
+
+const Label = styled.span`
+ overflow-wrap: anywhere;
+ white-space: pre-line;
+`;
+
+const RowBreak = styled.li`
+ flex-basis: 100%;
+ height: 0;
+`;
+
+export type TimeseriesLegendProps = TimeseriesCustomLegend & {
+ maxHeight: number;
+ onAll: () => void;
+ onInverse: () => void;
+ onToggle: (name: string) => void;
+};
+
+function TimeseriesLegend({
+ items,
+ maxHeight,
+ onAll,
+ onInverse,
+ onToggle,
+ showSelectors,
+}: TimeseriesLegendProps) {
+ if (items.length === 0 || maxHeight <= 0) {
+ return null;
+ }
+
+ return (
+ <LegendViewport data-test="timeseries-custom-legend" maxHeight={maxHeight}>
+ {showSelectors && (
+ <SelectorRow>
+ <SelectorButton type="button" onClick={onAll}>
+ {t('All')}
+ </SelectorButton>
+ <SelectorButton type="button" onClick={onInverse}>
+ {t('Inverse')}
+ </SelectorButton>
+ </SelectorRow>
+ )}
+ <ItemList>
+ {items.map((item, index) =>
+ item.name === '' || item.name === '\n' ? (
+ <RowBreak
+ // ECharts treats these exact values as row-break sentinels.
+ key={`row-break-${item.name}-${index}`}
+ />
+ ) : (
+ <LegendItem key={item.name}>
+ <ItemButton
Review Comment:
Not a blocker: the native ECharts legend highlights the hovered series by default (this file relies on that when it sets `legendHoverLink = false` for the color-by-x-axis proxies), but the HTML legend only wires click. Hovering a legend item no longer emphasizes its series, which is noticeable on dense charts. Since you already have `dispatchLegendAction`, this looks like a cheap add:
```tsx
onMouseEnter={() => onHover?.(item.name)}
onMouseLeave={() => onHover?.(null)}
```
with the handler dispatching `highlight`/`downplay` by seriesName. Fine as a follow-up if you'd rather keep this scoped.
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -1378,6 +1471,9 @@ export default function transformProps(
grid: {
...defaultGrid,
...padding,
+ // Compact charts prioritize a viable coordinate system over keeping
+ // axis labels inside an already constrained grid rectangle.
+ containLabel: !usesCompactLayout,
Review Comment:
Question, not necessarily a blocker: this flips `containLabel` off for every chart at or below `compactChartHeight`, even with no legend involved and even when the grid reservations fit. So every small dashboard cell now renders axis labels un-contained, where they can overlap the plot or clip at the canvas edge. The SSR tests pin the grid rectangle but not label behavior. Are we certain we want this for all compact charts, rather than only when the reservations actually exceed the budget? Or is there a rendering problem with `containLabel: true` at these heights that motivated it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5446573729
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/33127593028) for [560e5bf](https://github.com/apache/superset/commit/560e5bf)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5420810849
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/32932218668) for [9b8da16](https://github.com/apache/superset/commit/9b8da16)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5421110119
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/32933933666) for [f56c10f](https://github.com/apache/superset/commit/f56c10f)
• **Environment:** http://35.94.59.81:8080 (admin/admin)
• **Lifetime:** 48h auto-cleanup
• **Updates:** New commits create fresh environments automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5361242781
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/32413737054) for [5c0717f](https://github.com/apache/superset/commit/5c0717f)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5460206460
Heya @sadpandajoe, the title and description here are still describing the original margin-cap approach in `getHorizontalPlainLegendLayout` — but that file hasn't been touched since `bf16b511` swapped it for the new `TimeseriesLegend` component. Might be worth updating both, since right now they undersell what's actually being proposed: a custom HTML legend replacing ECharts' native one for Plain+Top/Bottom, not a margin tweak.
Otherwise this looks good to me. Capping the legend height instead of letting margin grow unbounded is the right call, and real `<button>`s beat ECharts' canvas legend on accessibility. Once the description catches up and the `review:draft` label comes off, LGTM from me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5417177489
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/32902129114) for [7bfef6e](https://github.com/apache/superset/commit/7bfef6e)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5418988230
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/32916268584) for [9a0670e](https://github.com/apache/superset/commit/9a0670e)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5446780092
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/33129298347) for [2f0d78d](https://github.com/apache/superset/commit/2f0d78d)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5376552254
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/32538122851) for [a80b964](https://github.com/apache/superset/commit/a80b964)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): render Plain Timeseries legends as HTML, not canvas [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5515298893
Good catch — the description was stale from before the swap to the custom `TimeseriesLegend` component. Updated the title and description to describe the current HTML-legend approach (rendered via `WithLegend` outside the ECharts canvas for Plain+Top/Bottom) rather than the original margin-cap. Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): render Plain Timeseries legends as HTML, not canvas [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #43314:
URL: https://github.com/apache/superset/pull/43314#discussion_r3919435938
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -1378,6 +1471,9 @@ export default function transformProps(
grid: {
...defaultGrid,
...padding,
+ // Compact charts prioritize a viable coordinate system over keeping
+ // axis labels inside an already constrained grid rectangle.
+ containLabel: !usesCompactLayout,
Review Comment:
Intentional, not an oversight. This is unconditional by design, for the same reason it's unconditional in `getViableTimeseriesEchartOptions` (transformers.ts:874-886): once a chart is compact, we can't know ahead of time how much space `containLabel: true` will reserve, since that depends on the actual label text (formatter output, rotation, locale, longest tick) which varies per query and isn't knowable at layout time. If we only disabled it when our clamped top/bottom reservations exceed `reservationBudget`, a compact chart with no explicit overrides could still hand ECharts an unbounded budget via `containLabel: true`, which can shrink the computed plot rect below `MIN_ECHARTS_GRID_HEIGHT` (or to zero) for long/rotated labels - which is exactly the collapse this PR (and 2f0d78d) is trying to prevent. Forcing it off for all compact charts trades 'labels may clip or overlap at the very edge' for 'the plot area is always guaranteed to be viable', which is the safer failure mode at
these heights. The added SSR/unit test ('keeps a no-legend grid within a very small post-control body') pins that guarantee.\n\nSo yes, we're intentionally doing this for all compact charts rather than only when reservations exceed budget - happy to revisit if there's a case where the label-overlap tradeoff is worse than the collapse it prevents, but I'd want a concrete repro first since narrowing this reintroduces the original bug for charts with long tick labels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5422189763
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5376333618
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | e4686828bcb25a61db236fad981a5c5fe2540881 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a88da521f55de000888658a |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-43314--superset-docs-preview.netlify.app](https://deploy-preview-43314--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DctBCoAgEEDRu8w6wQJj6AYdY2rGEkwHjSiiu-fuL95_QUs-9IQJoIOlUFr31j7cRiOFZKJsktjkS0okNWc4pEoJUhtn0ZifmdswEiKTG3rvHIu1FhFHhwTfDw) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-43314--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5335592494
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43314?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.00000%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.67%. Comparing base ([`34cd50c`](https://app.codecov.io/gh/apache/superset/commit/34cd50cc4840d72636f5d33c196ba3e0fcb8a7db?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b61414e`](https://app.codecov.io/gh/apache/superset/commit/b61414ed3aa8c6db52e6be226aa91878ed661649?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/43314?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...d/plugins/plugin-chart-echarts/src/utils/series.ts](https://app.codecov.io/gh/apache/superset/pull/43314?src=pr&el=tree&filepath=superset-frontend%2Fplugins%2Fplugin-chart-echarts%2Fsrc%2Futils%2Fseries.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvdXRpbHMvc2VyaWVzLnRz) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #43314 +/- ##
=======================================
Coverage 66.67% 66.67%
=======================================
Files 2876 2876
Lines 164007 164014 +7
Branches 37834 37837 +3
=======================================
+ Hits 109347 109355 +8
+ Misses 52514 52513 -1
Partials 2146 2146
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/43314/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/43314/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.91% <90.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43314?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5447577681
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): render Plain Timeseries legends as HTML, not canvas [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5519171146
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5446889022
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/33129298347) for [2f0d78d](https://github.com/apache/superset/commit/2f0d78d)
• **Environment:** http://44.243.247.238:8080 (admin/admin)
• **Lifetime:** 48h auto-cleanup
• **Updates:** New commits create fresh environments automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5446446877
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/33125454356) for [5f195cf](https://github.com/apache/superset/commit/5f195cf)
• **Environment:** http://16.146.79.93:8080 (admin/admin)
• **Lifetime:** 48h auto-cleanup
• **Updates:** New commits create fresh environments automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5417868254
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/32907430006) for [7723c95](https://github.com/apache/superset/commit/7723c95)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5418630317
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/32912765730) for [c2eb230](https://github.com/apache/superset/commit/c2eb230)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5420997394
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/32933933666) for [f56c10f](https://github.com/apache/superset/commit/f56c10f)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(echarts): reserve full margin for overflowing plain legends in Timeseries charts [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43314:
URL: https://github.com/apache/superset/pull/43314#issuecomment-5376323273
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/32535740470) for [e468682](https://github.com/apache/superset/commit/e468682)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org