You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/11/10 19:26:16 UTC

Review Request 15391: few cleanups in CertServiceTest and CertService

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15391/
-----------------------------------------------------------

Review request for cloudstack and Syed Ahmed.


Repository: cloudstack-git


Description
-------

Tests:
    - all tests are @Test rather than having one test to call them, so they can be run one by one
    - tests that expect exception from a method fail if there is none
    - no longer extends TestCase so that the original method names could be kept as test
    
    Implementation:
    - include root cause in exceptions when possible - helps at troubleshuting
    - close readers


Diffs
-----

  server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 53dae50 
  server/test/org/apache/cloudstack/network/lb/CertServiceTest.java e47fc01 

Diff: https://reviews.apache.org/r/15391/diff/


Testing
-------


Thanks,

Laszlo Hornyak

Re: Review Request 15391: few cleanups in CertServiceTest and CertService

Posted by Syed Ahmed <sa...@cloudops.com>.

> On Nov. 11, 2013, 8:32 p.m., Syed Ahmed wrote:
> > Ship It!

Hi Laszlo, 

Can you please move this to submitted if its done. 

Thanks,
-Syed


- Syed


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15391/#review28686
-----------------------------------------------------------


On Nov. 10, 2013, 6:26 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15391/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2013, 6:26 p.m.)
> 
> 
> Review request for cloudstack and Syed Ahmed.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Tests:
>     - all tests are @Test rather than having one test to call them, so they can be run one by one
>     - tests that expect exception from a method fail if there is none
>     - no longer extends TestCase so that the original method names could be kept as test
>     
>     Implementation:
>     - include root cause in exceptions when possible - helps at troubleshuting
>     - close readers
> 
> 
> Diffs
> -----
> 
>   server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 53dae50 
>   server/test/org/apache/cloudstack/network/lb/CertServiceTest.java e47fc01 
> 
> Diff: https://reviews.apache.org/r/15391/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>

Re: Review Request 15391: few cleanups in CertServiceTest and CertService

Posted by Syed Ahmed <sa...@cloudops.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15391/#review28686
-----------------------------------------------------------

Ship it!


Ship It!

- Syed Ahmed


On Nov. 10, 2013, 6:26 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15391/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2013, 6:26 p.m.)
> 
> 
> Review request for cloudstack and Syed Ahmed.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Tests:
>     - all tests are @Test rather than having one test to call them, so they can be run one by one
>     - tests that expect exception from a method fail if there is none
>     - no longer extends TestCase so that the original method names could be kept as test
>     
>     Implementation:
>     - include root cause in exceptions when possible - helps at troubleshuting
>     - close readers
> 
> 
> Diffs
> -----
> 
>   server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 53dae50 
>   server/test/org/apache/cloudstack/network/lb/CertServiceTest.java e47fc01 
> 
> Diff: https://reviews.apache.org/r/15391/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>