[GitHub] [samza] cameronlee314 commented on a change in pull request #1158: SAMZA-2324: Adding KV store metrics for rocksdb

[GitBox <gi...@apache.org>]

cameronlee314 commented on a change in pull request #1158: SAMZA-2324: Adding KV store metrics for rocksdb
URL: https://github.com/apache/samza/pull/1158#discussion_r325371636
 
 

 ##########
 File path: samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala
 ##########
 @@ -55,23 +55,27 @@ class SerializedKeyValueStore[K, V](
   }
 
   def put(key: K, value: V) {
-    metrics.puts.inc
     val keyBytes = toBytesOrNull(key, keySerde)
     val valBytes = toBytesOrNull(value, msgSerde)
     store.put(keyBytes, valBytes)
+    metrics.puts.inc
+    metrics.maxRecordSizeBytes.set(Math.max(metrics.maxRecordSizeBytes.getValue, valBytes.length))
 
 Review comment:
   I think there might be a concurrency bug here for exact correctness. If two threads try to set the max at the same time, you might not always ultimately get the max. This is just metrics though, so I'm not sure how important that is to get exact correctness.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services