You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Dave Brondsema <da...@brondsema.net> on 2017/09/19 14:44:38 UTC
[allura:tickets] #8164 Merge requests should notify the submitter of changes
---
** [tickets:#8164] Merge requests should notify the submitter of changes**
**Status:** open
**Milestone:** unreleased
**Labels:** merge-requests
**Created:** Tue Sep 19, 2017 02:44 PM UTC by Dave Brondsema
**Last Updated:** Tue Sep 19, 2017 02:44 PM UTC
**Owner:** nobody
The person that submits a merge request should get subscribed to it. Would be nice to have a subscribe icon button also, so that other people can subscribe (like tickets etc work). We'll have to adjust the message text a bit, the word "you" here is directed at project admins only:
> has requested that you merge changes
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8164 Merge requests should notify the submitter of changes
HAS MIGRATION SCRIPT
Posted by Dave Brondsema <da...@brondsema.net>.
- **Milestone**: unreleased --> v1.8.0
---
** [tickets:#8164] Merge requests should notify the submitter of changes HAS MIGRATION SCRIPT**
**Status:** closed
**Milestone:** v1.8.0
**Labels:** merge-requests
**Created:** Tue Sep 19, 2017 02:44 PM UTC by Dave Brondsema
**Last Updated:** Thu Sep 28, 2017 02:57 PM UTC
**Owner:** Dave Brondsema
The person that submits a merge request should get subscribed to it. Would be nice to have a subscribe icon button also, so that other people can subscribe (like tickets etc work). We'll have to adjust the message text a bit, the word "you" here is directed at project admins only:
> has requested that you merge changes
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8164 Merge requests should notify the submitter of changes
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: open --> in-progress
- **assigned_to**: Dave Brondsema
---
** [tickets:#8164] Merge requests should notify the submitter of changes**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** merge-requests
**Created:** Tue Sep 19, 2017 02:44 PM UTC by Dave Brondsema
**Last Updated:** Tue Sep 19, 2017 02:44 PM UTC
**Owner:** Dave Brondsema
The person that submits a merge request should get subscribed to it. Would be nice to have a subscribe icon button also, so that other people can subscribe (like tickets etc work). We'll have to adjust the message text a bit, the word "you" here is directed at project admins only:
> has requested that you merge changes
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8164 Merge requests should notify the submitter of changes
HAS MIGRATION SCRIPT
Posted by Dave Brondsema <da...@brondsema.net>.
- **summary**: Merge requests should notify the submitter of changes --> Merge requests should notify the submitter of changes HAS MIGRATION SCRIPT
- **status**: in-progress --> review
- **Comment**:
db/8164
QA, to reproduce:
* be on master, log in as a user that is not admin of a project (e.g. "root"), fork a repo, and submit a merge request. (The repo needs to be non-empty, merge request can actually be no changes though)
* as project *admin*, change and/or comment on the merge request
* watch email logs, e.g. `docker-compose logs -f outmail` and see notifications. See that the `TO: ` line goes to the project admin only
Now:
* switch to this branch
* `docker-compose restart taskd` to get some of the changes in effect
* create new merge request, comment/change as proj admin
* confirm merge request emails are sent to submitter now
* and icon to subscribe/unsubscribe to merge requests
* activity stream entries for all merge request changes, shows up for the user & project
* run `docker-compose run taskd paster script docker-dev.ini ../scripts/migrations/032-subscribe-merge-request-submitters.py` to resubscribe prior merge requests. Can confirm on /auth/subscriptions/ page.
---
** [tickets:#8164] Merge requests should notify the submitter of changes HAS MIGRATION SCRIPT**
**Status:** review
**Milestone:** unreleased
**Labels:** merge-requests
**Created:** Tue Sep 19, 2017 02:44 PM UTC by Dave Brondsema
**Last Updated:** Tue Sep 26, 2017 04:24 PM UTC
**Owner:** Dave Brondsema
The person that submits a merge request should get subscribed to it. Would be nice to have a subscribe icon button also, so that other people can subscribe (like tickets etc work). We'll have to adjust the message text a bit, the word "you" here is directed at project admins only:
> has requested that you merge changes
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8164 Merge requests should notify the submitter of changes
HAS MIGRATION SCRIPT
Posted by Kenton Taylor <kt...@slashdotmedia.com>.
- **status**: review --> closed
- **Comment**:
Merged.
---
** [tickets:#8164] Merge requests should notify the submitter of changes HAS MIGRATION SCRIPT**
**Status:** closed
**Milestone:** unreleased
**Labels:** merge-requests
**Created:** Tue Sep 19, 2017 02:44 PM UTC by Dave Brondsema
**Last Updated:** Tue Sep 26, 2017 06:39 PM UTC
**Owner:** Dave Brondsema
The person that submits a merge request should get subscribed to it. Would be nice to have a subscribe icon button also, so that other people can subscribe (like tickets etc work). We'll have to adjust the message text a bit, the word "you" here is directed at project admins only:
> has requested that you merge changes
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.