You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Shazron Abdullah (JIRA)" <ji...@apache.org> on 2017/06/21 08:18:00 UTC

[jira] [Comment Edited] (CB-12940) Use deployment-target for platform version in Podfile

    [ https://issues.apache.org/jira/browse/CB-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057126#comment-16057126 ] 

Shazron Abdullah edited comment on CB-12940 at 6/21/17 8:17 AM:
----------------------------------------------------------------

Line: https://github.com/apache/cordova-ios/blob/4490abf273ec6d12810c8ff5ea16d197c58ecd4b/bin/templates/scripts/cordova/lib/Podfile.js#L94

The Podfile constructor needs to be passed the deployment-target from the project config ConfigParser object here:
https://github.com/apache/cordova-ios/blob/df5441df874183d3d36b64e84969ebc7f0838f05/bin/templates/scripts/cordova/Api.js#L259
(a ConfigParser object can be created from this.locations.configXml)


was (Author: shazron):
Line: https://github.com/apache/cordova-ios/blob/4490abf273ec6d12810c8ff5ea16d197c58ecd4b/bin/templates/scripts/cordova/lib/Podfile.js#L94

The Podfile constructor needs to be passed the deployment-target from the project config ConfigParser object here:
https://github.com/apache/cordova-ios/blob/df5441df874183d3d36b64e84969ebc7f0838f05/bin/templates/scripts/cordova/Api.js#L259


> Use deployment-target for platform version in Podfile
> -----------------------------------------------------
>
>                 Key: CB-12940
>                 URL: https://issues.apache.org/jira/browse/CB-12940
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-ios
>    Affects Versions: cordova-ios@4.4.0
>            Reporter: Todd Miller
>            Assignee: Shazron Abdullah
>             Fix For: cordova-ios@4.4.1
>
>
> The current Podfile.js script is hardcoded to set the platform ios version to 8.0. However, there are some pods that require 9.0 or they will fail to install. The deployment-target preference should be honored and used when generating the Podfile.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org