You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2015/11/13 09:11:53 UTC

Review Request 40283: Fixed layer untar in registry puller.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40283/
-----------------------------------------------------------

Review request for mesos and Timothy Chen.


Repository: mesos


Description
-------

Changes:
  - Layer now untars into a separate directory.
  - Layers are downloaded with ".tar" extension.
  - Check for root permissions for untarring.


Diffs
-----

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 8a5691fb55afae305c9d1217341d6b1ceae7bded 

Diff: https://reviews.apache.org/r/40283/diff/


Testing
-------

make check; manual end-to-end testing with mesos-execute.


Thanks,

Jojy Varghese

Re: Review Request 40283: Fixed layer untar in registry puller.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40283/#review106387
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40283]

All tests passed.

- Mesos ReviewBot


On Nov. 13, 2015, 8:11 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40283/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 8:11 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changes:
>   - Layer now untars into a separate directory.
>   - Layers are downloaded with ".tar" extension.
>   - Check for root permissions for untarring.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 8a5691fb55afae305c9d1217341d6b1ceae7bded 
> 
> Diff: https://reviews.apache.org/r/40283/diff/
> 
> 
> Testing
> -------
> 
> make check; manual end-to-end testing with mesos-execute.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>