You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2025/07/04 15:56:19 UTC
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23121
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
KUDU-3662 [4/n] Add reader & writer config parsing
Adds configuration parsing for Kudu Source and Kudu Sink so that
replication jobs can be tuned without code changes.
* ReplicationEnvProvider now consumes the parsed configs.
* ReplicationTestBase auto-generates default reader/writer configs.
* Adds two unit tests in replication_config_parser_test to verify
correct deserialization and application of defaults.
Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
---
M java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java
M java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationEnvProvider.java
M java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationJob.java
M java/kudu-replication/src/test/java/org/apache/kudu/replication/ReplicationTestBase.java
M java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplication.java
M java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java
6 files changed, 199 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/23121/1
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 3: Code-Review+2
(5 comments)
Overall this patch LGTM.
I posted several questions on the behavior of the config parser, but I guess it's more about the behavior of Flink config parser itself.
If you think it makes sense to explicitly verify the questioned behavior in this context, maybe add corresponding test scenarios. Otherwise, feel free to submit this patch as-is once answering the questions in the review comments.
Thanks!
http://gerrit.cloudera.org:8080/#/c/23121/3/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java
File java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java:
http://gerrit.cloudera.org:8080/#/c/23121/3/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java@96
PS3, Line 96: "--reader.batchSizeBytes", "2048000",
What if there are duplicates in the config for a parameter? Would the config be valid, and if yes, then what would be the result value for the parameter that were retrieved by the corresponding getXxx() method?
http://gerrit.cloudera.org:8080/#/c/23121/3/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java@99
PS3, Line 99: "--reader.prefetching", "true",
Just curious: is the setting for this parameter is case-sensitive or not? Also, would '1' be converted into 'true' or it would be an invalid value?
http://gerrit.cloudera.org:8080/#/c/23121/3/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java@101
PS3, Line 101: CLOSEST_REPLICA
Just curious: is this parameter case-sensitive or not? E.g., if set to 'closest_replica', would the parsed result be the same when it's set to 'CLOSEST_REPLICA'?
http://gerrit.cloudera.org:8080/#/c/23121/3/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java@143
PS3, Line 143: 60000
Is it always expected to have numbers in decimal notation, or it recognizes and accepts values in hexadecimal as well? For example, what if this were '0x1000' instead of '60000'?
http://gerrit.cloudera.org:8080/#/c/23121/3/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java@144
PS3, Line 144: 5242880
What if setting this to something higher than 2^31 -- would that be an invalid value or it'd be accepted? If accepted, would it work as expected? BTW, are there 'no limit' semantics for this parameter?
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Jul 2025 15:39:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 3:
(5 comments)
Thanks for taking a look!
ParameterTool is already covered by tests in Flink:
https://github.com/a0x8o/flink/tree/941b7259fe26a82908204f1b8d66d436357c8a66/flink-java/src/test/java/org/apache/flink/api/java/utils
The rest of the open questions can be answered by examining the classes that ParameterTool relies on; I’ve added those findings to your comments. I decided not to add basic tests to our repository because they would introduce unnecessary bloat.
http://gerrit.cloudera.org:8080/#/c/23121/3/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java
File java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java:
http://gerrit.cloudera.org:8080/#/c/23121/3/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java@96
PS3, Line 96: "--reader.batchSizeBytes", "2048000",
> What if there are duplicates in the config for a parameter? Would the conf
It will throw IllegalStateException.class with message "Key <key> should has only one value" [1]
[1]: https://github.com/a0x8o/flink/blob/941b7259fe26a82908204f1b8d66d436357c8a66/flink-java/src/test/java/org/apache/flink/api/java/utils/MultipleParameterToolTest.java#L30-L66
http://gerrit.cloudera.org:8080/#/c/23121/3/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java@99
PS3, Line 99: "--reader.prefetching", "true",
> Just curious: is the setting for this parameter is case-sensitive or not?
In the end it uses Boolean.valueOf(String) , it only evaluates true if the argument is true, case insensitive.
http://gerrit.cloudera.org:8080/#/c/23121/3/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java@101
PS3, Line 101: CLOSEST_REPLICA
> Just curious: is this parameter case-sensitive or not? E.g., if set to 'cl
ParameterTool relies on Java’s Enum.valueOf(), which is case-sensitive. This requires exact match.
http://gerrit.cloudera.org:8080/#/c/23121/3/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java@143
PS3, Line 143: 60000
> Is it always expected to have numbers in decimal notation, or it recognizes
It is not expected, it will throw parsing error.
http://gerrit.cloudera.org:8080/#/c/23121/3/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java@144
PS3, Line 144: 5242880
> What if setting this to something higher than 2^31 -- would that be an inva
Yes there are.
ParameterTools getLong() function uses -> Long.parseLong(value) which if not within bounds throws NumberFormatException
Same for Int etc.
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Jul 2025 13:12:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 1:
Thanks for the patch!
My only ask would be to add some negative test cases to TestReplicationConfigParser, e.g. what would happen if a null value or random value was passed for the replicaSelection param? I haven't seen any detailed checks for that in ReplicationConfigParser either, only a null check.
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Jul 2025 13:15:50 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 3: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1590/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Jul 2025 11:15:27 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1540/
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Jul 2025 15:56:24 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 3: Verified+1
unrelated test failures:
release: org.apache.kudu.backup.TestKuduBackup, org.apache.kudu.spark.kudu.DefaultSourceTest
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Jul 2025 11:16:51 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 3:
(1 comment)
In the current test setup we use the defaults: the reader and writer configs only pass through the master addresses.
If your question is about verifying that setting a specific config parameter works, TestReplicationConfigParser.java covers that at the unit-test level. Beyond that, the Flink connectors simply receive the configs and it’s their responsibility to apply them. Both the Flink source and sink connectors are well tested.
Let me know if that answers your question.
http://gerrit.cloudera.org:8080/#/c/23121/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23121/3//COMMIT_MSG@13
PS3, Line 13: auto-generates
> nit: Is there any heuristics involved in coming up with default config?
In our test setup the default reader and writer configs just plumb the source/sink Kudu master addresses. It's just a test setup thingy.
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Jul 2025 14:40:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 2:
For the primitive types the param tool handles it, but I wasnt sure about the enum if that causes any issue. Added two tests to make sure we get proper errors.
Thank you for the question!
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jul 2025 15:26:03 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1540/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Jul 2025 17:09:01 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23121
to look at the new patch set (#2).
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
KUDU-3662 [4/n] Add reader & writer config parsing
Adds configuration parsing for Kudu Source and Kudu Sink so that
replication jobs can be tuned without code changes.
* ReplicationEnvProvider now consumes the parsed configs.
* ReplicationTestBase auto-generates default reader/writer configs.
* Adds two unit tests in replication_config_parser_test to verify
correct deserialization and application of defaults.
Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
---
M java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java
M java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationEnvProvider.java
M java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationJob.java
M java/kudu-replication/src/test/java/org/apache/kudu/replication/ReplicationTestBase.java
M java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplication.java
M java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java
6 files changed, 242 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/23121/2
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Jul 2025 09:30:31 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23121/2/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java
File java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java:
http://gerrit.cloudera.org:8080/#/c/23121/2/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java@118
PS2, Line 118: v
> nit: remove one space from here, because there seems to be two.
thanks! done.
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Jul 2025 10:10:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
LGTM!
Just one question: If default parameter values are set on config, do you think similar test verification is required for default parameter case?
Feel free to ignore if default parameter values are not applicable to Replication config.
http://gerrit.cloudera.org:8080/#/c/23121/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23121/3//COMMIT_MSG@13
PS3, Line 13: auto-generates
nit: Is there any heuristics involved in coming up with default config?
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Jul 2025 13:31:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Jul 2025 12:50:55 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 3:
> (1 comment)
>
> In the current test setup we use the defaults: the reader and
> writer configs only pass through the master addresses.
> If your question is about verifying that setting a specific config
> parameter works, TestReplicationConfigParser.java covers that at
> the unit-test level. Beyond that, the Flink connectors simply
> receive the configs and it’s their responsibility to apply them.
> Both the Flink source and sink connectors are well tested.
>
> Let me know if that answers your question.
Thanks for the clarification!
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Jul 2025 11:14:45 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1564/
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jul 2025 15:22:45 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 2: Verified+1
Build Successful
http://jenkins.kudu.apache.org/job/pre_commit/1564/ : SUCCESS
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jul 2025 16:33:37 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 2: Code-Review+1
> Patch Set 2:
>
> For the primitive types the param tool handles it, but I wasnt sure about the enum if that causes any issue. Added two tests to make sure we get proper errors.
> Thank you for the question!
Thank you!
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Jul 2025 07:30:06 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
KUDU-3662 [4/n] Add reader & writer config parsing
Adds configuration parsing for Kudu Source and Kudu Sink so that
replication jobs can be tuned without code changes.
* ReplicationEnvProvider now consumes the parsed configs.
* ReplicationTestBase auto-generates default reader/writer configs.
* Adds two unit tests in replication_config_parser_test to verify
correct deserialization and application of defaults.
Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Reviewed-on: http://gerrit.cloudera.org:8080/23121
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Gabriella Lotz <lo...@gmail.com>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Ashwani Raina <ar...@gmail.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
---
M java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java
M java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationEnvProvider.java
M java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationJob.java
M java/kudu-replication/src/test/java/org/apache/kudu/replication/ReplicationTestBase.java
M java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplication.java
M java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java
6 files changed, 242 insertions(+), 15 deletions(-)
Approvals:
Marton Greber: Verified
Gabriella Lotz: Looks good to me, but someone else must approve
Zoltan Chovan: Looks good to me, but someone else must approve
Ashwani Raina: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
Zoltan Martonka: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23121/2/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java
File java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java:
http://gerrit.cloudera.org:8080/#/c/23121/2/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java@118
PS2, Line 118:
nit: remove one space from here, because there seems to be two.
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Jul 2025 09:46:45 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Zoltan Martonka, Gabriella Lotz, Ashwani Raina, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23121
to look at the new patch set (#3).
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
KUDU-3662 [4/n] Add reader & writer config parsing
Adds configuration parsing for Kudu Source and Kudu Sink so that
replication jobs can be tuned without code changes.
* ReplicationEnvProvider now consumes the parsed configs.
* ReplicationTestBase auto-generates default reader/writer configs.
* Adds two unit tests in replication_config_parser_test to verify
correct deserialization and application of defaults.
Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
---
M java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java
M java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationEnvProvider.java
M java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationJob.java
M java/kudu-replication/src/test/java/org/apache/kudu/replication/ReplicationTestBase.java
M java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplication.java
M java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java
6 files changed, 242 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/23121/3
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 3:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1590/
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Jul 2025 10:09:09 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 3:
> (5 comments)
>
> Thanks for taking a look!
>
> ParameterTool is already covered by tests in Flink:
> https://github.com/a0x8o/flink/tree/941b7259fe26a82908204f1b8d66d436357c8a66/flink-java/src/test/java/org/apache/flink/api/java/utils
>
> The rest of the open questions can be answered by examining the
> classes that ParameterTool relies on; I’ve added those findings to
> your comments. I decided not to add basic tests to our repository
> because they would introduce unnecessary bloat.
That sounds good to me.
Thank you for the answers!
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Jul 2025 16:26:30 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3662 [4/n] Add reader & writer config parsing
Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9
Gerrit-Change-Number: 23121
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Jul 2025 09:28:10 +0000
Gerrit-HasComments: No