[GitHub] [superset] hughhhh commented on a diff in pull request #22304: feat: add Dataset tagging import/update api

[GitBox <gi...@apache.org>]

hughhhh commented on code in PR #22304:
URL: https://github.com/apache/superset/pull/22304#discussion_r1081859129


##########
superset/datasets/commands/importers/v1/utils.py:
##########
@@ -148,6 +156,26 @@ def import_dataset(
     return dataset
 
 
+def extract_tags(config: Dict[str, Any]) -> Tuple[Dict[str, Any], Optional[List[str]]]:

Review Comment:
   can we get a unit test for this util function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org