You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/12/05 14:11:59 UTC

[GitHub] [iceberg] xingbowu commented on pull request #3659: Aliyun: align property names with AWS module

xingbowu commented on pull request #3659:
URL: https://github.com/apache/iceberg/pull/3659#issuecomment-986237320


   Hi Jack, Regarding the name style of access key, I agree with you that the best way is to line up them between aws and aliyun module。however, considering legacy reason for user behavior,  we decided to keep it as it is.
   could you check the discussion comments in PR3553 https://github.com/apache/iceberg/pull/3553#discussion_r752046575
   feel free to let me know your further idea?
   
   it looks good to me to rename `AliyunClientFactories.load`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org