You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/28 17:25:50 UTC

[GitHub] [airflow] calebwoofenden opened a new issue, #27353: Upgrade to the latest version of bitnami/postgresql

calebwoofenden opened a new issue, #27353:
URL: https://github.com/apache/airflow/issues/27353

   ### Official Helm Chart version
   
   1.7.0 (latest released)
   
   ### Apache Airflow version
   
   2.4.2
   
   ### Kubernetes Version
   
   1.21
   
   ### Helm Chart configuration
   
   _No response_
   
   ### Docker Image customisations
   
   _No response_
   
   ### What happened
   
   This is a feature request for the helm chart. It's currently using bitnami/postgresql as a dependency chart when Postgres is enabled. It's pointing at version 10.5.3, which is over a year old. That chart has been updated significantly since then. It offers a lot of new features, and also has a lot of changes in variable names. This can make it difficult to customize values of that chart since you have to find the documentation for it at that version.
   
   ### What you think should happen instead
   
   _No response_
   
   ### How to reproduce
   
   _No response_
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk closed issue #27353: Upgrade to the latest version of bitnami/postgresql

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #27353: Upgrade to the latest version of bitnami/postgresql
URL: https://github.com/apache/airflow/issues/27353


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on issue #27353: Upgrade to the latest version of bitnami/postgresql

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #27353:
URL: https://github.com/apache/airflow/issues/27353#issuecomment-1295281641

   Why don't you raise a PR for that ? IT should be as easy as changing version and seeing if all tests pass?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] calebwoofenden commented on issue #27353: Upgrade to the latest version of bitnami/postgresql

Posted by GitBox <gi...@apache.org>.
calebwoofenden commented on issue #27353:
URL: https://github.com/apache/airflow/issues/27353#issuecomment-1295305930

   Can do, though I'm quite sure it will cause at least some problems. The documentation for the apache/airflow chart tells users to set `postgresql.postgresqlUsername` and `postgresql.postgresqlPassword`, which are variable names that are no longer used in the latest version of the postgresql chart. It looks like they've been renamed to `postgresql.auth.username` and `postgresql.auth.password`. I can make a branch and just replace these values and see if it works though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on issue #27353: Upgrade to the latest version of bitnami/postgresql

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #27353:
URL: https://github.com/apache/airflow/issues/27353#issuecomment-1295283407

   Update: It\s even easier - updating the Postgres Chart .tgz file to the right version in the PR - we changed it some time ago. @calebwoofenden - would you want to do it ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on issue #27353: Upgrade to the latest version of bitnami/postgresql

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #27353:
URL: https://github.com/apache/airflow/issues/27353#issuecomment-1295338164

   > Can do, though I'm quite sure it will cause at least some problems. The documentation for the apache/airflow chart tells users to set `postgresql.postgresqlUsername` and `postgresql.postgresqlPassword`, which are variable names that are no longer used in the latest version of the postgresql chart. It looks like they've been renamed to `postgresql.auth.username` and `postgresql.auth.password`. I can make a branch and just replace these values and see if it works though.
   
   So ..... opportunitu for an improvement then! You seem to know what to do - happy to help with reviewing it, and if they pass the  the Helm tests, you are sure it works (we are using the source Helm Chart to run Helm Kubernetes tests, so it is automatically tested. 
   
   Shall I assign you ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] calebwoofenden commented on issue #27353: Upgrade to the latest version of bitnami/postgresql

Posted by GitBox <gi...@apache.org>.
calebwoofenden commented on issue #27353:
URL: https://github.com/apache/airflow/issues/27353#issuecomment-1295431626

   Here ya go 😄 https://github.com/apache/airflow/pull/27357


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org