You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/11 02:05:58 UTC

[GitHub] [geode-native] moleske commented on a change in pull request #615: GEODE-8231: remove bucket server location from metadata when server down

moleske commented on a change in pull request #615:
URL: https://github.com/apache/geode-native/pull/615#discussion_r438502781



##########
File path: cppcache/integration/test/CMakeLists.txt
##########
@@ -27,6 +27,7 @@ add_executable(cpp-integration-test
   ExampleTest.cpp
   ExpirationTest.cpp
   FunctionExecutionTest.cpp
+  PartitionRegionOpsWithRedundancyAndServerGoesDown.cpp

Review comment:
       I think it general we've been having test files end in `Test` just to make it super obvious when browsing files it is a test.  Also the file reads more like a test case rather than an identifier for a set of tests.  I think the test file being called `PartitionRegionOpsTest.cpp` would work since you use `getPartitionedRegionWithRedundancyServerGoesDown` and putPartitionedRegionWithRedundancyServerGoesDown` as your test names.  We can see if others have thoughts about naming




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org