[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4701: Added support for removing unused port groups on VMWare

[GitBox <gi...@apache.org>]

sureshanaparti commented on a change in pull request #4701:
URL: https://github.com/apache/cloudstack/pull/4701#discussion_r591246254



##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManager.java
##########
@@ -46,6 +46,9 @@
     static final ConfigKey<Integer> s_vmwareOVAPackageTimeout = new ConfigKey<Integer>(Integer.class, "vmware.package.ova.timeout", "Advanced", "3600",
             "Vmware script timeout for ova packaging process", true, ConfigKey.Scope.Global, 1000);
 
+    static final ConfigKey<Boolean> s_vmwareCleanupPortGroups = new ConfigKey<Boolean>("Advanced", Boolean.class, "vmware.cleanup.port.groups",  "true",
+            "Remove unused port groups.", true, ConfigKey.Scope.Global);

Review comment:
       Any reason to keep default value 'true' ? I think, Default value 'false' will keep the old behavior after upgrade, and up to admin to set it to 'true' to cleanup the port groups.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org