[GitHub] [hawq] huor commented on a change in pull request #1494: HAWQ-1766. fix get hdfs file blocklocations

[GitBox <gi...@apache.org>]

huor commented on a change in pull request #1494:
URL: https://github.com/apache/hawq/pull/1494#discussion_r490084314



##########
File path: contrib/exthdfs/exthdfs.c
##########
@@ -137,65 +136,75 @@ Datum hdfsprotocol_blocklocation(PG_FUNCTION_ARGS)
 			}
 
 			// Get block location data for this file
-			BlockLocation *bla = hdfsGetFileBlockLocations(fs, fullpath, 0, len,&numOfBlock);
-			if (bla == NULL)
+			FscHdfsFileBlockLocationArrayC *bla =
+			    FscHdfsGetPathFileBlockLocation(fs, fullpath, 0, len);
+			if (FscHdfsHasErrorRaised(fs))
 			{
-				elog(ERROR, "hdfsprotocol_blocklocation : "
-							"failed to get block location of path %s. "
-							"It is reported generally due to HDFS service errors or "
-							"another session's ongoing writing.",
-							fullpath);
+			  Assert(bla == NULL);
+			  CatchedError *ce = FscHdfsGetFileSystemError(fs);

Review comment:
        这个地方拿了ce但没用，是不是应该报错里输入出来？




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org