You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/08 12:21:06 UTC
[GitHub] [superset] kaihenzler opened a new issue #17686: Third party plugin not working anymore due to monorepo migration
kaihenzler opened a new issue #17686:
URL: https://github.com/apache/superset/issues/17686
I'm maintaining a third party viz plugin over at: https://github.com/w11k/superset-chart-plugins
With the recent merge of the superset-ui repo and the main repo (https://github.com/apache/superset/issues/13013) a issue with local development for third party plugins was introduced.
#### How to reproduce the bug
When using `npm link` with any third party viz plugin and starting the superset dev server like usual I now get the following React error message (see below): which leads to the following page: https://fb.me/react-invalid-hook-call
### Expected results
The third party plugin works like usual when using `npm link`
### Actual results
React error message:
#### Screenshots
...
### Environment
(please complete the following information):
- browser type and version: Every Browser
- superset version: latest (master)`1.3.2`
- python version: -
- node.js version: `14.x`
- any feature flags active:
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Can be fixed by adding an alias to react in the [`webpack.config.js` Line 286](https://github.com/apache/superset/blob/c4b04952d0e446b2347d2e6928478e2207102567/superset-frontend/webpack.config.js#L286)
```javascript
alias: {
react: path.resolve('./node_modules/react'),
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #17686: Third party plugin not working anymore due to monorepo migration
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #17686:
URL: https://github.com/apache/superset/issues/17686#issuecomment-1014557322
@kaihenzler to add to @amitmiran137 's answer, the Yeoman generator template has been updated to work with the new monorepo, and the currently valid instructions can be found in the updated docs here: https://github.com/apache/superset/blob/master/docs/src/pages/docs/Contributing/creating-viz-plugins.mdx . The code that the new template creates is easier to work with, incl. no npm linking required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kaihenzler commented on issue #17686: Third party plugin not working anymore due to monorepo migration
Posted by GitBox <gi...@apache.org>.
kaihenzler commented on issue #17686:
URL: https://github.com/apache/superset/issues/17686#issuecomment-996761568
@villebro thanks a lot for the update. I'm looking forward to try the new template
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kaihenzler commented on issue #17686: Third party plugin not working anymore due to monorepo migration
Posted by GitBox <gi...@apache.org>.
kaihenzler commented on issue #17686:
URL: https://github.com/apache/superset/issues/17686#issuecomment-1014559909
Thanks a ton! I will have a look at it soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on issue #17686: Third party plugin not working anymore due to monorepo migration
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #17686:
URL: https://github.com/apache/superset/issues/17686#issuecomment-996465938
yup, guessing somehow you ended up with another version of react running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #17686: Third party plugin not working anymore due to monorepo migration
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #17686:
URL: https://github.com/apache/superset/issues/17686#issuecomment-996766515
@kaihenzler I took a look at your repo, very exciting to see custom viz plugins in the wild! If you want to get a head start on this stuff please ping me on Slack so I can share my WIP code. The new template should simplify your repo considerably by removing the `lerna` dependency, unless you want to keep it as a monorepo, that is. I consider the new template quite stable, but as it may still change in the coming days I want to wait a few more days before opening a PR for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #17686: Third party plugin not working anymore due to monorepo migration
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #17686:
URL: https://github.com/apache/superset/issues/17686#issuecomment-996758652
@kaihenzler yes, the recent monorepo work caused this, and adding that alias does indeed fix it. FYI, you may very well run into other problems, too, but the good news is I've rebuilt the hello world plugin this week and totally decoupled it from the old `superset-ui` monorepo. The new template
- has build scripts and everything necessary to both develop, build and publish to npm
- can be npm linked with minimal effort from the main repo
I should have the `generator-superset` package updated early next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 commented on issue #17686: Third party plugin not working anymore due to monorepo migration
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on issue #17686:
URL: https://github.com/apache/superset/issues/17686#issuecomment-1003650639
Take a look at nielsen-oss/superset-viz-plugins
We manage to overcome all of the new setup issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 closed issue #17686: Third party plugin not working anymore due to monorepo migration
Posted by GitBox <gi...@apache.org>.
amitmiran137 closed issue #17686:
URL: https://github.com/apache/superset/issues/17686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kaihenzler commented on issue #17686: Third party plugin not working anymore due to monorepo migration
Posted by GitBox <gi...@apache.org>.
kaihenzler commented on issue #17686:
URL: https://github.com/apache/superset/issues/17686#issuecomment-996782686
Thanks a lot. I'll probably take a look at it after the holidays
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro edited a comment on issue #17686: Third party plugin not working anymore due to monorepo migration
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on issue #17686:
URL: https://github.com/apache/superset/issues/17686#issuecomment-1014557322
@kaihenzler to add to @amitmiran137 's answer, the Yeoman generator template has been updated to work with the new monorepo, and the currently valid instructions can be found in the updated docs here: https://github.com/apache/superset/blob/master/docs/src/pages/docs/Contributing/creating-viz-plugins.mdx . The code that the new template creates is easier to work with than the old one, incl. no npm linking required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org