You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tianyi Wang (Code Review)" <ge...@cloudera.org> on 2018/07/18 18:36:17 UTC

[Impala-ASF-CR] IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog

Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10965


Change subject: IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog
......................................................................

IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog

This patch bumps glog version to 0.3.4-p3 to include the patch limiting
fadvise calls.

Change-Id: I41fd855fbf0e9ec58845ac0d2eb96a87b0172152
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/10965/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41fd855fbf0e9ec58845ac0d2eb96a87b0172152
Gerrit-Change-Number: 10965
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>

[Impala-ASF-CR] IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10965 )

Change subject: IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog
......................................................................


Patch Set 2:

hit IMPALA-7316


-- 
To view, visit http://gerrit.cloudera.org:8080/10965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41fd855fbf0e9ec58845ac0d2eb96a87b0172152
Gerrit-Change-Number: 10965
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Jul 2018 01:23:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10965 )

Change subject: IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/10965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41fd855fbf0e9ec58845ac0d2eb96a87b0172152
Gerrit-Change-Number: 10965
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Jul 2018 04:34:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10965 )

Change subject: IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41fd855fbf0e9ec58845ac0d2eb96a87b0172152
Gerrit-Change-Number: 10965
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 20:35:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10965 )

Change subject: IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2838/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/10965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41fd855fbf0e9ec58845ac0d2eb96a87b0172152
Gerrit-Change-Number: 10965
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Jul 2018 01:24:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10965 )

Change subject: IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2834/


-- 
To view, visit http://gerrit.cloudera.org:8080/10965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41fd855fbf0e9ec58845ac0d2eb96a87b0172152
Gerrit-Change-Number: 10965
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 22:07:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10965 )

Change subject: IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog
......................................................................

IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog

This patch bumps glog version to 0.3.4-p3 to include the patch limiting
fadvise calls.

Change-Id: I41fd855fbf0e9ec58845ac0d2eb96a87b0172152
Reviewed-on: http://gerrit.cloudera.org:8080/10965
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/10965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I41fd855fbf0e9ec58845ac0d2eb96a87b0172152
Gerrit-Change-Number: 10965
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10965 )

Change subject: IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41fd855fbf0e9ec58845ac0d2eb96a87b0172152
Gerrit-Change-Number: 10965
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 18:37:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10965 )

Change subject: IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2834/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/10965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41fd855fbf0e9ec58845ac0d2eb96a87b0172152
Gerrit-Change-Number: 10965
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 20:35:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10965 )

Change subject: IMPALA-7252: Backport rate limiting of fadvise calls into toolchain glog
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41fd855fbf0e9ec58845ac0d2eb96a87b0172152
Gerrit-Change-Number: 10965
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Jul 2018 01:24:20 +0000
Gerrit-HasComments: No