You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/24 09:35:39 UTC
[GitHub] [skywalking] shichaoyuan opened a new issue, #9837: [Bug] JVMMetricsHandler histogramBatch has some error
shichaoyuan opened a new issue, #9837:
URL: https://github.com/apache/skywalking/issues/9837
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
### Apache SkyWalking Component
OAP server (apache/skywalking)
### What happened
`MeterServiceHandler`
```
histogram = metricsCreator.createHistogramMetric(
"meter_in_latency",
"The process latency of meter",
new MetricsTag.Keys("protocol"),
new MetricsTag.Values("kafka")
);
histogramBatch = metricsCreator.createHistogramMetric(
"meter_in_latency",
"The process latency of meter",
new MetricsTag.Keys("protocol"),
new MetricsTag.Values("kafka")
);
```
`histogramBatch` has the same name as `histogram`
### What you expected to happen
the name of `histogramBatch` should be "meter_batch_in_latency" or some other.
### How to reproduce
none
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #9837: [Bug] JVMMetricsHandler histogramBatch has some error
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #9837: [Bug] JVMMetricsHandler histogramBatch has some error
URL: https://github.com/apache/skywalking/issues/9837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] shichaoyuan commented on issue #9837: [Bug] JVMMetricsHandler histogramBatch has some error
Posted by GitBox <gi...@apache.org>.
shichaoyuan commented on issue #9837:
URL: https://github.com/apache/skywalking/issues/9837#issuecomment-1288755998
https://github.com/apache/skywalking/blob/9d3982db74dbe7ba9c028aef674ace13fb74cc18/oap-server/server-fetcher-plugin/kafka-fetcher-plugin/src/main/java/org/apache/skywalking/oap/server/analyzer/agent/kafka/provider/handler/JVMMetricsHandler.java#L59-L70
sorry, here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9837: [Bug] JVMMetricsHandler histogramBatch has some error
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9837:
URL: https://github.com/apache/skywalking/issues/9837#issuecomment-1288747473
What is the issue actually?
https://github.com/apache/skywalking/blob/9d3982db74dbe7ba9c028aef674ace13fb74cc18/oap-server/server-fetcher-plugin/kafka-fetcher-plugin/src/main/java/org/apache/skywalking/oap/server/analyzer/agent/kafka/provider/handler/MeterServiceHandler.java#L73-L79
From here, they are measure different things, so they are using different metric names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] shichaoyuan commented on issue #9837: [Bug] JVMMetricsHandler histogramBatch has some error
Posted by GitBox <gi...@apache.org>.
shichaoyuan commented on issue #9837:
URL: https://github.com/apache/skywalking/issues/9837#issuecomment-1288793859
got it, thank you for your detailed explanation.
I think both are ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9837: [Bug] JVMMetricsHandler histogramBatch has some error
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9837:
URL: https://github.com/apache/skywalking/issues/9837#issuecomment-1288784529
No matter `meter_in_latency` or `meter_batch_in_latency`, they are both wrong actually. JVM metric is not using any meter kernel to process.
Two options
1. Remove these metrics from JVMMetricsHandler to keep consistent with JVM gRPC receiver.
2. Make it right. Also, you have to add those metrics in JVM gRPC receivers, and update the dashboard for grafana and SkyWalking self-obs dashboard.
From my understanding, these metrics don't make much sense. I prefer <1>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] shichaoyuan commented on issue #9837: [Bug] JVMMetricsHandler histogramBatch has some error
Posted by GitBox <gi...@apache.org>.
shichaoyuan commented on issue #9837:
URL: https://github.com/apache/skywalking/issues/9837#issuecomment-1288778808
I just read this part of code in "kafka-fetcher-plugin", not pay attention to other related code.
As you replied firstly, `histogram` and `histogramBatch` should use different metric names in `JVMMetricsHandler`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9837: [Bug] JVMMetricsHandler histogramBatch has some error
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9837:
URL: https://github.com/apache/skywalking/issues/9837#issuecomment-1288765365
I think those should be removed. I took a look at `JVMMetricReportServiceHandler`. There is no self-obs metric actually for the JVM receiver.
What proposal are you going to do? Remove these metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9837: [Bug] JVMMetricsHandler histogramBatch has some error
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9837:
URL: https://github.com/apache/skywalking/issues/9837#issuecomment-1288804404
This is an easy fix, we prefer you could submit a pull request to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org