You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/04 10:17:08 UTC

[GitHub] [pulsar] nicoloboschi commented on a change in pull request #13131: Make tests can run on jdk17+

nicoloboschi commented on a change in pull request #13131:
URL: https://github.com/apache/pulsar/pull/13131#discussion_r762410409



##########
File path: pom.xml
##########
@@ -1814,6 +1814,29 @@ flexible messaging model and an intuitive client API.</description>
         </pluginManagement>
       </build>
     </profile>
+    <profile>
+      <id>jdk17</id>
+      <activation>
+        <jdk>[17,)</jdk>

Review comment:
       +1 for not adding new profile, to me it's useful only if something not related only to the tests is different

##########
File path: pom.xml
##########
@@ -1814,6 +1814,29 @@ flexible messaging model and an intuitive client API.</description>
         </pluginManagement>
       </build>
     </profile>
+    <profile>
+      <id>jdk17</id>
+      <activation>
+        <jdk>[17,)</jdk>

Review comment:
       +1 for not adding a new profile, to me it's useful only if something not related only to the tests is different




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org