You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2018/07/10 10:48:36 UTC
[GitHub] carbondata pull request #2476: [CARBONDATA-2534][MV] Fix substring expressio...
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2476
[CARBONDATA-2534][MV] Fix substring expression not working in MV creation
This PR depends on https://github.com/apache/carbondata/pull/2453
Problem: The column generated when subquery expression column present is wrong while creating of MV table.
Solution: Corrected the column name by removing special characters.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravipesala/incubator-carbondata mv-2534
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2476.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2476
----
commit 844cff764e94f18ff8d115ccd636a06a0931bffb
Author: ravipesala <ra...@...>
Date: 2018-06-14T06:10:07Z
Fixed order by in mv and aggregation functions inside projection expressions are fixed
commit 9c5c6ccf7cf506d46ef02f339d3e3aa260f4d7ef
Author: ravipesala <ra...@...>
Date: 2018-07-10T10:41:28Z
Fix substring issue
----
---
[GitHub] carbondata issue #2476: [CARBONDATA-2534][MV] Fix substring expression not w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2476
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7414/
---
[GitHub] carbondata issue #2476: [CARBONDATA-2534][MV] Fix substring expression not w...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2476
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5851/
---
[GitHub] carbondata issue #2476: [CARBONDATA-2534][MV] Fix substring expression not w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2476
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7194/
---
[GitHub] carbondata issue #2476: [CARBONDATA-2534][MV] Fix substring expression not w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2476
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6008/
---
[GitHub] carbondata pull request #2476: [CARBONDATA-2534][MV] Fix substring expressio...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2476#discussion_r202544380
--- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala ---
@@ -119,7 +119,12 @@ object MVHelper {
}
def updateColumnName(attr: Attribute): String = {
- val name = attr.name.replace("(", "_").replace(")", "").replace(" ", "_").replace("=", "")
+ val name =
+ attr.name.replace("(", "_").
--- End diff --
please put `.` to next line
---
[GitHub] carbondata issue #2476: [CARBONDATA-2534][MV] Fix substring expression not w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2476
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5767/
---
[GitHub] carbondata issue #2476: [CARBONDATA-2534][MV] Fix substring expression not w...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2476
LGTM
please rebase
---
[GitHub] carbondata issue #2476: [CARBONDATA-2534][MV] Fix substring expression not w...
Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:
https://github.com/apache/carbondata/pull/2476
retest sdv please
---
[GitHub] carbondata issue #2476: [CARBONDATA-2534][MV] Fix substring expression not w...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2476
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5950/
---
[GitHub] carbondata issue #2476: [CARBONDATA-2534][MV] Fix substring expression not w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2476
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6178/
---
[GitHub] carbondata issue #2476: [CARBONDATA-2534][MV] Fix substring expression not w...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2476
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5744/
---
[GitHub] carbondata pull request #2476: [CARBONDATA-2534][MV] Fix substring expressio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2476
---
[GitHub] carbondata issue #2476: [CARBONDATA-2534][MV] Fix substring expression not w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2476
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6989/
---
[GitHub] carbondata issue #2476: [CARBONDATA-2534][MV] Fix substring expression not w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2476
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7235/
---
[GitHub] carbondata issue #2476: [CARBONDATA-2534][MV] Fix substring expression not w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2476
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5969/
---
[GitHub] carbondata issue #2476: [CARBONDATA-2534][MV] Fix substring expression not w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2476
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7092/
---
[GitHub] carbondata issue #2476: [CARBONDATA-2534][MV] Fix substring expression not w...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2476
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5860/
---
[GitHub] carbondata pull request #2476: [CARBONDATA-2534][MV] Fix substring expressio...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2476#discussion_r202889166
--- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala ---
@@ -119,7 +119,12 @@ object MVHelper {
}
def updateColumnName(attr: Attribute): String = {
- val name = attr.name.replace("(", "_").replace(")", "").replace(" ", "_").replace("=", "")
+ val name =
+ attr.name.replace("(", "_").
--- End diff --
ok
---