You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "JayajP (via GitHub)" <gi...@apache.org> on 2025/12/12 22:44:49 UTC
[PR] Refresh Iceberg Table metadata every 2 minutes instead of before each intermediate file written [beam]
JayajP opened a new pull request, #37102:
URL: https://github.com/apache/beam/pull/37102
When we use the Iceberg Sink with the BLMS Catalog, refreshing the table metadata uses a BLMS Read Quota. The default quota is 300 read requests a second.
* Currently, send a read request before every intermediate file we write to ensure the partition spec is up to date. This exhausts the BLMS Read quota for pipelines with non-trivial load.
* After this PR we will only reload the Iceberg Table metadata every 2 minutes per-worker. Now a dataflow job with 100 workers will only use 50 out of the 300 read requests a minute.
Tested through unit tests and a by launching a pipeline. https://screenshot.googleplex.com/BdB7Nqx2EUYeUZo
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refresh Iceberg Table metadata every 2 minutes instead of before each intermediate file written [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #37102:
URL: https://github.com/apache/beam/pull/37102#issuecomment-3648409482
## Summary of Changes
Hello @JayajP, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a performance bottleneck in the Iceberg Sink when interacting with the BLMS Catalog. Previously, table metadata was refreshed excessively, leading to frequent exhaustion of read quotas. The core change introduces a time-based caching mechanism that refreshes table metadata only once every two minutes per worker, drastically reducing the load on the catalog and improving the stability of data pipelines.
### Highlights
* **Optimized Iceberg Metadata Refresh**: The frequency of refreshing Iceberg table metadata has been changed from 'before every intermediate file write' to 'every 2 minutes per worker'.
* **Reduced BLMS Read Quota Usage**: This change significantly lowers the number of read requests to the BLMS Catalog, preventing quota exhaustion in high-load pipelines.
* **Introduced Time-Based Caching**: A new LastRefreshedTable class and LAST_REFRESHED_TABLE_CACHE now manage table objects, refreshing them only when metadata is considered stale (older than 3 minutes).
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refresh Iceberg Table metadata every 2 minutes instead of before each intermediate file written [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #37102:
URL: https://github.com/apache/beam/pull/37102#discussion_r2615872744
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/RecordWriterManager.java:
##########
@@ -256,8 +259,40 @@ static String getPartitionDataPath(
private final Map<WindowedValue<IcebergDestination>, List<SerializableDataFile>>
totalSerializableDataFiles = Maps.newHashMap();
+ static final class LastRefreshedTable {
+ final Table table;
+ volatile Instant lastRefreshTime;
+ static final Duration STALENESS_THRESHOLD = Duration.ofMinutes(3);
+
+ LastRefreshedTable(Table table, Instant lastRefreshTime) {
+ this.table = table;
+ this.lastRefreshTime = lastRefreshTime;
+ }
+
+ /**
+ * Refreshes the table metadata if it is considered stale (older than 3 minutes).
Review Comment:
The staleness threshold is set to 3 minutes, but the pull request description mentions 2 minutes: "After this PR we will only reload the Iceberg Table metadata every 2 minutes per-worker." To ensure consistency between the code, its documentation, and the PR description, I recommend changing this to 2 minutes.
```suggestion
static final Duration STALENESS_THRESHOLD = Duration.ofMinutes(2);
LastRefreshedTable(Table table, Instant lastRefreshTime) {
this.table = table;
this.lastRefreshTime = lastRefreshTime;
}
/**
* Refreshes the table metadata if it is considered stale (older than 2 minutes).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refresh Iceberg Table metadata every 2 minutes instead of before each intermediate file written [beam]
Posted by "JayajP (via GitHub)" <gi...@apache.org>.
JayajP commented on code in PR #37102:
URL: https://github.com/apache/beam/pull/37102#discussion_r2615876064
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/RecordWriterManager.java:
##########
@@ -256,8 +259,40 @@ static String getPartitionDataPath(
private final Map<WindowedValue<IcebergDestination>, List<SerializableDataFile>>
totalSerializableDataFiles = Maps.newHashMap();
+ static final class LastRefreshedTable {
+ final Table table;
+ volatile Instant lastRefreshTime;
+ static final Duration STALENESS_THRESHOLD = Duration.ofMinutes(3);
+
+ LastRefreshedTable(Table table, Instant lastRefreshTime) {
+ this.table = table;
+ this.lastRefreshTime = lastRefreshTime;
+ }
+
+ /**
+ * Refreshes the table metadata if it is considered stale (older than 3 minutes).
Review Comment:
Updated the code to reflect this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refresh Iceberg Table metadata every 2 minutes instead of before each intermediate file written [beam]
Posted by "JayajP (via GitHub)" <gi...@apache.org>.
JayajP commented on PR #37102:
URL: https://github.com/apache/beam/pull/37102#issuecomment-3657688002
No, I only checked at 2 minutes. This seemed like a safe value since a job with 100 workers would only consume 1/6th of the default read quota. Project's with larger usages would likely have quota overrides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refresh Iceberg Table metadata every 2 minutes instead of before each intermediate file written [beam]
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on PR #37102:
URL: https://github.com/apache/beam/pull/37102#issuecomment-3661510281
Sounds good, let's get this on for now and see how users react (if they prefer a quicker refresh interval or not)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refresh Iceberg Table metadata every 2 minutes instead of before each intermediate file written [beam]
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 merged PR #37102:
URL: https://github.com/apache/beam/pull/37102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refresh Iceberg Table metadata every 2 minutes instead of before each intermediate file written [beam]
Posted by "JayajP (via GitHub)" <gi...@apache.org>.
JayajP commented on PR #37102:
URL: https://github.com/apache/beam/pull/37102#issuecomment-3648553512
R: @ahmedabu98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refresh Iceberg Table metadata every 2 minutes instead of before each intermediate file written [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37102:
URL: https://github.com/apache/beam/pull/37102#issuecomment-3648555122
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refresh Iceberg Table metadata every 2 minutes instead of before each intermediate file written [beam]
Posted by "JayajP (via GitHub)" <gi...@apache.org>.
JayajP commented on PR #37102:
URL: https://github.com/apache/beam/pull/37102#issuecomment-3648544552
/gemini review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org