You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/16 13:38:15 UTC
[GitHub] [arrow] wesm opened a new pull request #7448: ARROW-9143: [C++] Do not produce internal ArrayData with kUnknownNullCount in RecordBatch::Slice if source ArrayData::null_count is set to 0
wesm opened a new pull request #7448:
URL: https://github.com/apache/arrow/pull/7448
This field being non-zero caused code paths that assumed `buffers[0]` to be non-null.
I also changed `ArrayData::Slice` to return a shared_ptr since there's little useful about a stack-allocated ArrayData
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7448: ARROW-9143: [C++] Do not produce internal ArrayData with kUnknownNullCount in RecordBatch::Slice if source ArrayData::null_count is set to 0
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7448:
URL: https://github.com/apache/arrow/pull/7448
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7448: ARROW-9143: [C++] Do not produce internal ArrayData with kUnknownNullCount in RecordBatch::Slice if source ArrayData::null_count is set to 0
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7448:
URL: https://github.com/apache/arrow/pull/7448#issuecomment-644849249
thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7448: ARROW-9143: [C++] Do not produce internal ArrayData with kUnknownNullCount in RecordBatch::Slice if source ArrayData::null_count is set to 0
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7448:
URL: https://github.com/apache/arrow/pull/7448#issuecomment-644788666
The RTools 4.0 build is flaking this morning
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7448: ARROW-9143: [C++] Do not produce internal ArrayData with kUnknownNullCount in RecordBatch::Slice if source ArrayData::null_count is set to 0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7448:
URL: https://github.com/apache/arrow/pull/7448#issuecomment-644776603
https://issues.apache.org/jira/browse/ARROW-9143
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org