You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/13 11:52:32 UTC
[GitHub] [hbase] wchevreuil opened a new pull request #1027: HBASE-23683
Make HBaseInterClusterReplicationEndpoint more extensible
wchevreuil opened a new pull request #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027
Defines create methods for Connection and ReplicationSinkManager instances.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] binlijin commented on issue #1027: HBASE-23683 Make
HBaseInterClusterReplicationEndpoint more extensible
Posted by GitBox <gi...@apache.org>.
binlijin commented on issue #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027#issuecomment-573959305
Agree with Bharath, others are good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1027: HBASE-23683 Make
HBaseInterClusterReplicationEndpoint more extensible
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027#issuecomment-574285694
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 49s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 46s | master passed |
| +1 :green_heart: | compile | 1m 8s | master passed |
| +1 :green_heart: | checkstyle | 1m 39s | master passed |
| +1 :green_heart: | shadedjars | 6m 2s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 43s | master passed |
| +0 :ok: | spotbugs | 5m 6s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 5m 4s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 44s | the patch passed |
| +1 :green_heart: | compile | 1m 13s | the patch passed |
| +1 :green_heart: | javac | 1m 13s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 40s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 6m 1s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 20m 47s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 40s | the patch passed |
| +1 :green_heart: | findbugs | 5m 13s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 162m 49s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 31s | The patch does not generate ASF License warnings. |
| | | 237m 2s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1027 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux b59be7c10ad1 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1027/out/precommit/personality/provided.sh |
| git revision | master / 499ff32f00 |
| Default Java | 1.8.0_181 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/4/testReport/ |
| Max. process+thread count | 4780 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/4/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] binlijin commented on a change in pull request #1027:
HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
Posted by GitBox <gi...@apache.org>.
binlijin commented on a change in pull request #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027#discussion_r365772202
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java
##########
@@ -113,6 +113,14 @@
private boolean dropOnDeletedTables;
private boolean isSerial = false;
+ protected Connection createConnection(Configuration conf) throws IOException {
+ return ConnectionFactory.createConnection(conf);
Review comment:
This is wrong? Should be ClusterConnectionFactory.createAsyncClusterConnection?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1027: HBASE-23683 Make
HBaseInterClusterReplicationEndpoint more extensible
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027#issuecomment-573641789
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 47s | master passed |
| +1 :green_heart: | compile | 0m 58s | master passed |
| +1 :green_heart: | checkstyle | 1m 31s | master passed |
| +1 :green_heart: | shadedjars | 4m 56s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 36s | master passed |
| +0 :ok: | spotbugs | 4m 53s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 51s | master passed |
||| _ Patch Compile Tests _ |
| -1 :x: | mvninstall | 2m 41s | root in the patch failed. |
| -1 :x: | compile | 0m 40s | hbase-server in the patch failed. |
| -1 :x: | javac | 0m 40s | hbase-server in the patch failed. |
| +1 :green_heart: | checkstyle | 1m 28s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | shadedjars | 3m 43s | patch has 17 errors when building our shaded downstream artifacts. |
| -1 :x: | hadoopcheck | 1m 55s | The patch causes 17 errors with Hadoop v2.8.5. |
| -1 :x: | hadoopcheck | 3m 57s | The patch causes 17 errors with Hadoop v2.9.2. |
| -1 :x: | hadoopcheck | 6m 1s | The patch causes 17 errors with Hadoop v3.1.2. |
| +1 :green_heart: | javadoc | 0m 34s | the patch passed |
| -1 :x: | findbugs | 0m 40s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 41s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. |
| | | 38m 7s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1027 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 33c8da345eb9 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1027/out/precommit/personality/provided.sh |
| git revision | master / 0bf933b068 |
| Default Java | 1.8.0_181 |
| mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/1/artifact/out/patch-mvninstall-root.txt |
| compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/1/artifact/out/patch-compile-hbase-server.txt |
| javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/1/artifact/out/patch-compile-hbase-server.txt |
| shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/1/artifact/out/patch-shadedjars.txt |
| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/1/artifact/out/patch-javac-2.8.5.txt |
| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/1/artifact/out/patch-javac-2.9.2.txt |
| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/1/artifact/out/patch-javac-3.1.2.txt |
| findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/1/artifact/out/patch-findbugs-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/1/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/1/testReport/ |
| Max. process+thread count | 86 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] wchevreuil merged pull request #1027: HBASE-23683 Make
HBaseInterClusterReplicationEndpoint more extensible
Posted by GitBox <gi...@apache.org>.
wchevreuil merged pull request #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1027:
HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027#discussion_r365994648
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java
##########
@@ -113,6 +113,15 @@
private boolean dropOnDeletedTables;
private boolean isSerial = false;
+ protected AsyncClusterConnection createConnection(Configuration conf) throws IOException {
Review comment:
nit: Add a quick comment why these exist as protected? Otherwise it can confuse the readers because the only callers in the source are in this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] wchevreuil commented on a change in pull request #1027:
HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
Posted by GitBox <gi...@apache.org>.
wchevreuil commented on a change in pull request #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027#discussion_r365784402
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java
##########
@@ -113,6 +113,14 @@
private boolean dropOnDeletedTables;
private boolean isSerial = false;
+ protected Connection createConnection(Configuration conf) throws IOException {
+ return ConnectionFactory.createConnection(conf);
Review comment:
Yeah, this was originally for a branch-2 based code. Had fixed it on the latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] wchevreuil commented on a change in pull request #1027:
HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
Posted by GitBox <gi...@apache.org>.
wchevreuil commented on a change in pull request #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027#discussion_r365785358
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java
##########
@@ -113,6 +113,14 @@
private boolean dropOnDeletedTables;
private boolean isSerial = false;
+ protected Connection createConnection(Configuration conf) throws IOException {
+ return ConnectionFactory.createConnection(conf);
+ }
+
+ protected ReplicationSinkManager createReplicationSinkManager(AsyncClusterConnection conn) {
+ return new ReplicationSinkManager(conn,this, this.conf);
Review comment:
Fixed on last commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1027:
HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027#discussion_r365994362
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java
##########
@@ -131,13 +140,12 @@ public void init(Context context) throws IOException {
// TODO: This connection is replication specific or we should make it particular to
// replication and make replication specific settings such as compression or codec to use
// passing Cells.
- this.conn =
- ClusterConnectionFactory.createAsyncClusterConnection(conf, null, User.getCurrent());
+ this.conn = (AsyncClusterConnection) createConnection(this.conf);
Review comment:
nit: redundant cast..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] wchevreuil commented on issue #1027: HBASE-23683 Make
HBaseInterClusterReplicationEndpoint more extensible
Posted by GitBox <gi...@apache.org>.
wchevreuil commented on issue #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027#issuecomment-574199277
Thanks for the reviews @bharathv, @binlijin and @joshelser.
> Maybe something we should lift up to an abstract and limited-private base class later? Looks like HBASE-15982 made this private in 2.0.0 (intentionally). So, maybe any further refactoring would be more complicated than I initially thought :)
Did notice that, but then the whole hierarchy from _BaseReplicationEndpoint_ downwards is marked as such. As you said, there could be some extra refactoring. I'm not sure why it has been made private by HBASE-15982, was it because there are still plans to move out from the guava service API dependency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1027: HBASE-23683 Make
HBaseInterClusterReplicationEndpoint more extensible
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027#issuecomment-573746108
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 50s | master passed |
| +1 :green_heart: | compile | 0m 56s | master passed |
| +1 :green_heart: | checkstyle | 1m 29s | master passed |
| +1 :green_heart: | shadedjars | 5m 0s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | master passed |
| +0 :ok: | spotbugs | 4m 58s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 57s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 23s | the patch passed |
| +1 :green_heart: | compile | 0m 56s | the patch passed |
| +1 :green_heart: | javac | 0m 56s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 27s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 56s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 2s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 35s | the patch passed |
| +1 :green_heart: | findbugs | 4m 55s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 154m 33s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. |
| | | 216m 15s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1027 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux ed1d4ecedb63 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1027/out/precommit/personality/provided.sh |
| git revision | master / 0bf933b068 |
| Default Java | 1.8.0_181 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/2/testReport/ |
| Max. process+thread count | 4961 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/2/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1027: HBASE-23683 Make
HBaseInterClusterReplicationEndpoint more extensible
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027#issuecomment-573842497
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 53s | master passed |
| +1 :green_heart: | compile | 0m 58s | master passed |
| +1 :green_heart: | checkstyle | 1m 30s | master passed |
| +1 :green_heart: | shadedjars | 4m 58s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | master passed |
| +0 :ok: | spotbugs | 4m 54s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 52s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 24s | the patch passed |
| +1 :green_heart: | compile | 0m 58s | the patch passed |
| +1 :green_heart: | javac | 0m 58s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 26s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 57s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 6s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 36s | the patch passed |
| +1 :green_heart: | findbugs | 5m 21s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 152m 42s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. |
| | | 214m 42s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1027 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux be039d359925 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1027/out/precommit/personality/provided.sh |
| git revision | master / 0bf933b068 |
| Default Java | 1.8.0_181 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/3/testReport/ |
| Max. process+thread count | 5123 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1027/3/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] binlijin commented on a change in pull request #1027:
HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
Posted by GitBox <gi...@apache.org>.
binlijin commented on a change in pull request #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible
URL: https://github.com/apache/hbase/pull/1027#discussion_r365772325
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java
##########
@@ -113,6 +113,14 @@
private boolean dropOnDeletedTables;
private boolean isSerial = false;
+ protected Connection createConnection(Configuration conf) throws IOException {
+ return ConnectionFactory.createConnection(conf);
+ }
+
+ protected ReplicationSinkManager createReplicationSinkManager(AsyncClusterConnection conn) {
+ return new ReplicationSinkManager(conn,this, this.conf);
Review comment:
need to format the code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services