You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/13 06:36:11 UTC

[GitHub] [arrow-rs] HaoYang670 commented on issue #1531: Epic: enhance the `substring` kernel

HaoYang670 commented on issue #1531:
URL: https://github.com/apache/arrow-rs/issues/1531#issuecomment-1097613212

   Hi @alamb. After thinking twice about the renaming, I suggest we leave the `substring by byte` as the implicit version, and make `substring by char` as an explicit version, so that we can make minimize API change (because the current `substring` is `by byte`) and easily extend the function:
   
   | function name | Supported array|
   |-------|------------------|
   | substring| StringArray(by byte)(slow), BinaryArray, FixedSizeBinary, FixedSizedListArray, ListArray|
   | unsafe substring| StringArray(by byte)(fast), and more if we find invalid outputs in the future|
   | substring_by_char| StringArray|
   
   In this way, the back compatibility will not be broken. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org