You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/09/17 10:36:26 UTC

Review Request 68734: Refactored new CLI.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68734/
-----------------------------------------------------------

Review request for mesos, Eric Chung and Kevin Klues.


Bugs: MESOS-8795
    https://issues.apache.org/jira/browse/MESOS-8795


Repository: mesos


Description
-------

This adds two new files, `agent.py` and `tasks.py`, usable by
any plugin to do standard operations with agents and tasks.


Diffs
-----

  src/python/cli_new/lib/cli/agents.py PRE-CREATION 
  src/python/cli_new/lib/cli/plugins/agent/main.py fc62d9fe62001e31d254a038cd7056751c846541 
  src/python/cli_new/lib/cli/plugins/task/main.py 644e256ce898784ce3511c30a373595ace149db9 
  src/python/cli_new/lib/cli/tasks.py PRE-CREATION 


Diff: https://reviews.apache.org/r/68734/diff/1/


Testing
-------

Ran `mesos-cli-tests` successfully.


Thanks,

Armand Grillet

Re: Review Request 68734: Refactored new CLI.

Posted by Kevin Klues <kl...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68734/#review209148
-----------------------------------------------------------


Ship it!




Armand and I sat together and modified this RR.

We decided to move the functionality spread across two files (tasks.py and agents.py) into a single mesos.py that has functions to abstract the various Mesos API calls. The main logic remains the same, it is just rearranged.

- Kevin Klues


On Sept. 17, 2018, 10:36 vorm., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68734/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2018, 10:36 vorm.)
> 
> 
> Review request for mesos, Eric Chung and Kevin Klues.
> 
> 
> Bugs: MESOS-8795
>     https://issues.apache.org/jira/browse/MESOS-8795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds two new files, `agent.py` and `tasks.py`, usable by
> any plugin to do standard operations with agents and tasks.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/lib/cli/agents.py PRE-CREATION 
>   src/python/cli_new/lib/cli/plugins/agent/main.py fc62d9fe62001e31d254a038cd7056751c846541 
>   src/python/cli_new/lib/cli/plugins/task/main.py 644e256ce898784ce3511c30a373595ace149db9 
>   src/python/cli_new/lib/cli/tasks.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68734/diff/1/
> 
> 
> Testing
> -------
> 
> Ran `mesos-cli-tests` successfully.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>