You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Citron, David" <dc...@sonusnet.com> on 2008/10/02 22:19:53 UTC
Re: svn commit: r701087 - in /incubator/shindig/trunk/java: server/src/test/java/org/apache/shindig/server/endtoend/ social-api/src/main/java/org/apache/shindig/social/core/config/ social-api/src/main/java/org/apache/shindig/social/opensocial/serviceLink
Maybe I'm confused, but this patch fix seems to have broken my build.
The patch refers to two files:
1)
java/social-api/src/main/java/org/apache/shindig/social/core/config/Soci
alApiGuiceModule.java
2)
java/social-api/src/main/java/org/apache/shindig/social/sample/service/S
ampleContainerHandlerProvider.java
File "2" was deleted with a previous patch (701087) and as such does not
exist anymore, yet the patch fix changes file "1" to refer to class "2",
hence the build error:
C:/dev/shindig/java/social-api/src/main/java/org/apache/shindig/social/c
ore/config/SocialApiGuiceModule.java:[31,48] cannot find symbol
symbol : class SampleContainerHandlerProvider
location: package org.apache.shindig.social.sample.service
Is something messed up in my configuration?
Thanks,
Dave
Re: svn commit: r701087 - in /incubator/shindig/trunk/java: server/src/test/java/org/apache/shindig/server/endtoend/ social-api/src/main/java/org/apache/shindig/social/core/config/ social-api/src/main/java/org/apache/shindig/social/opensocial/serviceLink
Posted by Ian Boston <ie...@tfd.co.uk>.
Ok looking at it again, the issue has been updated since I applied
the patch so I will see what hapend.
Ian
On 2 Oct 2008, at 21:36, Citron, David wrote:
> Actually, it's still broken.
>
> The original patch was applied correctly, but
> SampleContainerHandlerProvider.java was never reinstated during
> application of shindig-638-fix.patch.
>
> Thanks,
> Dave
>
> -----Original Message-----
> From: Ian Boston [mailto:ianboston@googlemail.com] On Behalf Of Ian
> Boston
> Sent: Thursday, October 02, 2008 4:29 PM
> To: shindig-dev@incubator.apache.org
> Subject: Re: svn commit: r701087 - in /incubator/shindig/trunk/java:
> server/src/test/java/org/apache/shindig/server/endtoend/
> social-api/src/main/java/org/apache/shindig/social/core/config/
> social-api/src/main/java/org/apache/shindig/social/opensocial/
> serviceLin
> k
>
> Looks like Adam got there before me.
> Thanks Adam. (for fixing my mistake:))
>
> Ian
> On 2 Oct 2008, at 21:19, Citron, David wrote:
>
>> Maybe I'm confused, but this patch fix seems to have broken my build.
>>
>> The patch refers to two files:
>>
>> 1)
>> java/social-api/src/main/java/org/apache/shindig/social/core/config/
>> Soci
>> alApiGuiceModule.java
>>
>> 2)
>> java/social-api/src/main/java/org/apache/shindig/social/sample/
>> service/S
>> ampleContainerHandlerProvider.java
>>
>> File "2" was deleted with a previous patch (701087) and as such
>> does not
>> exist anymore, yet the patch fix changes file "1" to refer to class
>> "2",
>> hence the build error:
>>
>> C:/dev/shindig/java/social-api/src/main/java/org/apache/shindig/
>> social/c
>> ore/config/SocialApiGuiceModule.java:[31,48] cannot find symbol
>> symbol : class SampleContainerHandlerProvider
>> location: package org.apache.shindig.social.sample.service
>>
>> Is something messed up in my configuration?
>>
>> Thanks,
>> Dave
>
RE: svn commit: r701087 - in /incubator/shindig/trunk/java: server/src/test/java/org/apache/shindig/server/endtoend/ social-api/src/main/java/org/apache/shindig/social/core/config/ social-api/src/main/java/org/apache/shindig/social/opensocial/serviceLink
Posted by "Citron, David" <dc...@sonusnet.com>.
Fixed! Thanks!
-----Original Message-----
From: Ian Boston [mailto:ianboston@googlemail.com] On Behalf Of Ian
Boston
Sent: Thursday, October 02, 2008 4:48 PM
To: shindig-dev@incubator.apache.org
Subject: Re: svn commit: r701087 - in /incubator/shindig/trunk/java:
server/src/test/java/org/apache/shindig/server/endtoend/
social-api/src/main/java/org/apache/shindig/social/core/config/
social-api/src/main/java/org/apache/shindig/social/opensocial/serviceLin
k
Should be fixed now, re-applying the patches from 638 fixed it.
Ian
On 2 Oct 2008, at 21:36, Citron, David wrote:
> Actually, it's still broken.
>
> The original patch was applied correctly, but
> SampleContainerHandlerProvider.java was never reinstated during
> application of shindig-638-fix.patch.
>
> Thanks,
> Dave
>
> -----Original Message-----
> From: Ian Boston [mailto:ianboston@googlemail.com] On Behalf Of Ian
> Boston
> Sent: Thursday, October 02, 2008 4:29 PM
> To: shindig-dev@incubator.apache.org
> Subject: Re: svn commit: r701087 - in /incubator/shindig/trunk/java:
> server/src/test/java/org/apache/shindig/server/endtoend/
> social-api/src/main/java/org/apache/shindig/social/core/config/
> social-api/src/main/java/org/apache/shindig/social/opensocial/
> serviceLin
> k
>
> Looks like Adam got there before me.
> Thanks Adam. (for fixing my mistake:))
>
> Ian
> On 2 Oct 2008, at 21:19, Citron, David wrote:
>
>> Maybe I'm confused, but this patch fix seems to have broken my build.
>>
>> The patch refers to two files:
>>
>> 1)
>> java/social-api/src/main/java/org/apache/shindig/social/core/config/
>> Soci
>> alApiGuiceModule.java
>>
>> 2)
>> java/social-api/src/main/java/org/apache/shindig/social/sample/
>> service/S
>> ampleContainerHandlerProvider.java
>>
>> File "2" was deleted with a previous patch (701087) and as such
>> does not
>> exist anymore, yet the patch fix changes file "1" to refer to class
>> "2",
>> hence the build error:
>>
>> C:/dev/shindig/java/social-api/src/main/java/org/apache/shindig/
>> social/c
>> ore/config/SocialApiGuiceModule.java:[31,48] cannot find symbol
>> symbol : class SampleContainerHandlerProvider
>> location: package org.apache.shindig.social.sample.service
>>
>> Is something messed up in my configuration?
>>
>> Thanks,
>> Dave
>
Re: svn commit: r701087 - in /incubator/shindig/trunk/java: server/src/test/java/org/apache/shindig/server/endtoend/ social-api/src/main/java/org/apache/shindig/social/core/config/ social-api/src/main/java/org/apache/shindig/social/opensocial/serviceLink
Posted by Ian Boston <ie...@tfd.co.uk>.
Should be fixed now, re-applying the patches from 638 fixed it.
Ian
On 2 Oct 2008, at 21:36, Citron, David wrote:
> Actually, it's still broken.
>
> The original patch was applied correctly, but
> SampleContainerHandlerProvider.java was never reinstated during
> application of shindig-638-fix.patch.
>
> Thanks,
> Dave
>
> -----Original Message-----
> From: Ian Boston [mailto:ianboston@googlemail.com] On Behalf Of Ian
> Boston
> Sent: Thursday, October 02, 2008 4:29 PM
> To: shindig-dev@incubator.apache.org
> Subject: Re: svn commit: r701087 - in /incubator/shindig/trunk/java:
> server/src/test/java/org/apache/shindig/server/endtoend/
> social-api/src/main/java/org/apache/shindig/social/core/config/
> social-api/src/main/java/org/apache/shindig/social/opensocial/
> serviceLin
> k
>
> Looks like Adam got there before me.
> Thanks Adam. (for fixing my mistake:))
>
> Ian
> On 2 Oct 2008, at 21:19, Citron, David wrote:
>
>> Maybe I'm confused, but this patch fix seems to have broken my build.
>>
>> The patch refers to two files:
>>
>> 1)
>> java/social-api/src/main/java/org/apache/shindig/social/core/config/
>> Soci
>> alApiGuiceModule.java
>>
>> 2)
>> java/social-api/src/main/java/org/apache/shindig/social/sample/
>> service/S
>> ampleContainerHandlerProvider.java
>>
>> File "2" was deleted with a previous patch (701087) and as such
>> does not
>> exist anymore, yet the patch fix changes file "1" to refer to class
>> "2",
>> hence the build error:
>>
>> C:/dev/shindig/java/social-api/src/main/java/org/apache/shindig/
>> social/c
>> ore/config/SocialApiGuiceModule.java:[31,48] cannot find symbol
>> symbol : class SampleContainerHandlerProvider
>> location: package org.apache.shindig.social.sample.service
>>
>> Is something messed up in my configuration?
>>
>> Thanks,
>> Dave
>
RE: svn commit: r701087 - in /incubator/shindig/trunk/java: server/src/test/java/org/apache/shindig/server/endtoend/ social-api/src/main/java/org/apache/shindig/social/core/config/ social-api/src/main/java/org/apache/shindig/social/opensocial/serviceLink
Posted by "Citron, David" <dc...@sonusnet.com>.
Actually, it's still broken.
The original patch was applied correctly, but
SampleContainerHandlerProvider.java was never reinstated during
application of shindig-638-fix.patch.
Thanks,
Dave
-----Original Message-----
From: Ian Boston [mailto:ianboston@googlemail.com] On Behalf Of Ian
Boston
Sent: Thursday, October 02, 2008 4:29 PM
To: shindig-dev@incubator.apache.org
Subject: Re: svn commit: r701087 - in /incubator/shindig/trunk/java:
server/src/test/java/org/apache/shindig/server/endtoend/
social-api/src/main/java/org/apache/shindig/social/core/config/
social-api/src/main/java/org/apache/shindig/social/opensocial/serviceLin
k
Looks like Adam got there before me.
Thanks Adam. (for fixing my mistake:))
Ian
On 2 Oct 2008, at 21:19, Citron, David wrote:
> Maybe I'm confused, but this patch fix seems to have broken my build.
>
> The patch refers to two files:
>
> 1)
> java/social-api/src/main/java/org/apache/shindig/social/core/config/
> Soci
> alApiGuiceModule.java
>
> 2)
> java/social-api/src/main/java/org/apache/shindig/social/sample/
> service/S
> ampleContainerHandlerProvider.java
>
> File "2" was deleted with a previous patch (701087) and as such
> does not
> exist anymore, yet the patch fix changes file "1" to refer to class
> "2",
> hence the build error:
>
> C:/dev/shindig/java/social-api/src/main/java/org/apache/shindig/
> social/c
> ore/config/SocialApiGuiceModule.java:[31,48] cannot find symbol
> symbol : class SampleContainerHandlerProvider
> location: package org.apache.shindig.social.sample.service
>
> Is something messed up in my configuration?
>
> Thanks,
> Dave
Re: svn commit: r701087 - in /incubator/shindig/trunk/java: server/src/test/java/org/apache/shindig/server/endtoend/ social-api/src/main/java/org/apache/shindig/social/core/config/ social-api/src/main/java/org/apache/shindig/social/opensocial/serviceLink
Posted by Ian Boston <ie...@tfd.co.uk>.
Looks like Adam got there before me.
Thanks Adam. (for fixing my mistake:))
Ian
On 2 Oct 2008, at 21:19, Citron, David wrote:
> Maybe I'm confused, but this patch fix seems to have broken my build.
>
> The patch refers to two files:
>
> 1)
> java/social-api/src/main/java/org/apache/shindig/social/core/config/
> Soci
> alApiGuiceModule.java
>
> 2)
> java/social-api/src/main/java/org/apache/shindig/social/sample/
> service/S
> ampleContainerHandlerProvider.java
>
> File "2" was deleted with a previous patch (701087) and as such
> does not
> exist anymore, yet the patch fix changes file "1" to refer to class
> "2",
> hence the build error:
>
> C:/dev/shindig/java/social-api/src/main/java/org/apache/shindig/
> social/c
> ore/config/SocialApiGuiceModule.java:[31,48] cannot find symbol
> symbol : class SampleContainerHandlerProvider
> location: package org.apache.shindig.social.sample.service
>
> Is something messed up in my configuration?
>
> Thanks,
> Dave
RE: svn commit: r701087 - in /incubator/shindig/trunk/java: server/src/test/java/org/apache/shindig/server/endtoend/ social-api/src/main/java/org/apache/shindig/social/core/config/ social-api/src/main/java/org/apache/shindig/social/opensocial/serviceLink
Posted by "Citron, David" <dc...@sonusnet.com>.
On closer inspection, it looks like the issue is probably that the
original SHINDIG-638 patch applier deleted
SampleContainerHandlerProvider.java, but the shindig-638-fix.patch
applier did not reinstate that file....correct?
Thanks,
Dave
-----Original Message-----
From: Ian Boston [mailto:ianboston@googlemail.com] On Behalf Of Ian
Boston
Sent: Thursday, October 02, 2008 4:26 PM
To: shindig-dev@incubator.apache.org
Subject: Re: svn commit: r701087 - in /incubator/shindig/trunk/java:
server/src/test/java/org/apache/shindig/server/endtoend/
social-api/src/main/java/org/apache/shindig/social/core/config/
social-api/src/main/java/org/apache/shindig/social/opensocial/serviceLin
k
Highly probably I applied the patches in the wrong order, let me
check and fix, I will get back to you ASAP.
Sorry.
Ian
On 2 Oct 2008, at 21:19, Citron, David wrote:
> Maybe I'm confused, but this patch fix seems to have broken my build.
>
> The patch refers to two files:
>
> 1)
> java/social-api/src/main/java/org/apache/shindig/social/core/config/
> Soci
> alApiGuiceModule.java
>
> 2)
> java/social-api/src/main/java/org/apache/shindig/social/sample/
> service/S
> ampleContainerHandlerProvider.java
>
> File "2" was deleted with a previous patch (701087) and as such
> does not
> exist anymore, yet the patch fix changes file "1" to refer to class
> "2",
> hence the build error:
>
> C:/dev/shindig/java/social-api/src/main/java/org/apache/shindig/
> social/c
> ore/config/SocialApiGuiceModule.java:[31,48] cannot find symbol
> symbol : class SampleContainerHandlerProvider
> location: package org.apache.shindig.social.sample.service
>
> Is something messed up in my configuration?
>
> Thanks,
> Dave
Re: svn commit: r701087 - in /incubator/shindig/trunk/java: server/src/test/java/org/apache/shindig/server/endtoend/ social-api/src/main/java/org/apache/shindig/social/core/config/ social-api/src/main/java/org/apache/shindig/social/opensocial/serviceLink
Posted by Ian Boston <ie...@tfd.co.uk>.
Highly probably I applied the patches in the wrong order, let me
check and fix, I will get back to you ASAP.
Sorry.
Ian
On 2 Oct 2008, at 21:19, Citron, David wrote:
> Maybe I'm confused, but this patch fix seems to have broken my build.
>
> The patch refers to two files:
>
> 1)
> java/social-api/src/main/java/org/apache/shindig/social/core/config/
> Soci
> alApiGuiceModule.java
>
> 2)
> java/social-api/src/main/java/org/apache/shindig/social/sample/
> service/S
> ampleContainerHandlerProvider.java
>
> File "2" was deleted with a previous patch (701087) and as such
> does not
> exist anymore, yet the patch fix changes file "1" to refer to class
> "2",
> hence the build error:
>
> C:/dev/shindig/java/social-api/src/main/java/org/apache/shindig/
> social/c
> ore/config/SocialApiGuiceModule.java:[31,48] cannot find symbol
> symbol : class SampleContainerHandlerProvider
> location: package org.apache.shindig.social.sample.service
>
> Is something messed up in my configuration?
>
> Thanks,
> Dave