You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/07/15 18:34:00 UTC
[jira] [Commented] (IMPALA-11389) Produce Python 3-compatible eggs in shell tarball
[ https://issues.apache.org/jira/browse/IMPALA-11389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567354#comment-17567354 ]
ASF subversion and git services commented on IMPALA-11389:
----------------------------------------------------------
Commit 64b324ac40c09c2358a96e848ac123db2790d211 in impala's branch refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=64b324ac4 ]
IMPALA-11389: Include Python 3 eggs in tarball
Build Python 3 eggs for the shell tarball so it works with both Python 2
and Python 3. The impala-shell script selects eggs based on the
available Python version.
Inlines thrift for impala-shell so we can easily build Python 2 and
Python 3 versions, consistent with other libraries. The impala-shell
version should always be at least as new as IMPALA_THRIFT_PY_VERSION.
Thrift 0.13.0+ wraps all exceptions during TSocket read/write operations
in TTransportException. Specifically socket.error that we got as raw
exceptions are now wrapped. Unwraps them before raising to preserve
prior behavior.
A specific Python version can be selected with IMPALA_PYTHON_EXECUTABLE;
otherwise it will use 'python', and if unavailable try 'python3'.
Adds tests for impala-shell tarball with Python 3.
Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Reviewed-on: http://gerrit.cloudera.org:8080/18653
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Produce Python 3-compatible eggs in shell tarball
> -------------------------------------------------
>
> Key: IMPALA-11389
> URL: https://issues.apache.org/jira/browse/IMPALA-11389
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Michael Smith
> Assignee: Michael Smith
> Priority: Major
> Fix For: Impala 4.2.0
>
>
> The shell tarball produced with {{make shell_tarball}} is currently Python 2-specific. We'd like to be able to use that tarball with Python 3 as well. We can do that by producing both Python 2 and Python 3 eggs, and having the impala-shell script select which to use based on the available Python version.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org