You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2017/05/15 15:02:01 UTC
zeppelin git commit: [minor] Replace 'SIMPLE' auth with 'simple' auth
everywhere in documents
Repository: zeppelin
Updated Branches:
refs/heads/master 5fde8c21d -> 95980c7ac
[minor] Replace 'SIMPLE' auth with 'simple' auth everywhere in documents
### What is this PR for?
This PR fixes a security hole in documentation when 'SIMPLE' authentication mechanism is defined in Shiro configuration (http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/security/shiroauthentication.html). With that, user can log in without entering his/her password. Zeppelin documentation should recommend the correct value which is 'simple'.
### What type of PR is it?
Documentation
### What is the Jira issue?
N/A
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
Author: Vipin Rathor <v....@gmail.com>
Closes #2331 from VipinRathor/fix-SIMPLE-auth-doc and squashes the following commits:
a1f0e48 [Vipin Rathor] [minor] Replace 'SIMPLE' auth with 'simple' auth everywhere in documents
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/95980c7a
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/95980c7a
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/95980c7a
Branch: refs/heads/master
Commit: 95980c7ac0d3b53bb3068bfed630b5afd61cadaa
Parents: 5fde8c2
Author: Vipin Rathor <v....@gmail.com>
Authored: Wed May 10 03:25:51 2017 -0700
Committer: Lee moon soo <mo...@apache.org>
Committed: Mon May 15 08:01:58 2017 -0700
----------------------------------------------------------------------
conf/shiro.ini.template | 2 +-
docs/security/shiroauthentication.md | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/95980c7a/conf/shiro.ini.template
----------------------------------------------------------------------
diff --git a/conf/shiro.ini.template b/conf/shiro.ini.template
index 8f40d23..0a3187a 100644
--- a/conf/shiro.ini.template
+++ b/conf/shiro.ini.template
@@ -43,7 +43,7 @@ user3 = password4, role2
#ldapRealm.contextFactory.environment[ldap.searchBase] = dc=COMPANY,dc=COM
#ldapRealm.contextFactory.url = ldap://ldap.test.com:389
#ldapRealm.userDnTemplate = uid={0},ou=Users,dc=COMPANY,dc=COM
-#ldapRealm.contextFactory.authenticationMechanism = SIMPLE
+#ldapRealm.contextFactory.authenticationMechanism = simple
### A sample PAM configuration
#pamRealm=org.apache.zeppelin.realm.PamRealm
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/95980c7a/docs/security/shiroauthentication.md
----------------------------------------------------------------------
diff --git a/docs/security/shiroauthentication.md b/docs/security/shiroauthentication.md
index 452600d..348c438 100644
--- a/docs/security/shiroauthentication.md
+++ b/docs/security/shiroauthentication.md
@@ -85,7 +85,7 @@ ldapRealm = org.apache.zeppelin.server.LdapGroupRealm
ldapRealm.contextFactory.environment[ldap.searchBase] = dc=COMPANY,dc=COM
ldapRealm.contextFactory.url = ldap://ldap.test.com:389
ldapRealm.userDnTemplate = uid={0},ou=Users,dc=COMPANY,dc=COM
-ldapRealm.contextFactory.authenticationMechanism = SIMPLE
+ldapRealm.contextFactory.authenticationMechanism = simple
```
also define roles/groups that you want to have in system, like below;
@@ -134,7 +134,7 @@ ldapRealm = org.apache.zeppelin.realm.LdapGroupRealm
ldapRealm.contextFactory.environment[ldap.searchBase] = dc=COMPANY,dc=COM
ldapRealm.contextFactory.url = ldap://ldap.test.com:389
ldapRealm.userDnTemplate = uid={0},ou=Users,dc=COMPANY,dc=COM
-ldapRealm.contextFactory.authenticationMechanism = SIMPLE
+ldapRealm.contextFactory.authenticationMechanism = simple
```
### PAM