You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/06/13 12:42:17 UTC
Review Request: Fix for CLOUDSTACK-2502 and CLOUDSTACK-2939
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11860/
-----------------------------------------------------------
Review request for cloudstack and Nitin Mehta.
Description
-------
CLOUDSTACK-2502: Scalevm and over provisioning should
respect each other
During Scale up of VM, memory/cpu calculations should consider the memory/cpu overprovisioning factors which are set per cluster.
CLOUDSTACK-2939: CPU limit is not getting set for vm after scaleup to a service offering which have cpu cap enabled
This addresses bugs CLOUDSTACK-2502 and CLOUDSTACK-2939.
Diffs
-----
core/src/com/cloud/agent/api/ScaleVmCommand.java 35d22ad
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 46219c3
plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java 3ca0b60
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e92c3fc
plugins/hypervisors/xen/test/com/cloud/hypervisor/xen/resource/CitrixResourceBaseTest.java 3328d4b
server/src/com/cloud/hypervisor/HypervisorGuruBase.java d8945af
server/src/com/cloud/vm/VirtualMachineManagerImpl.java 568fe55
server/test/com/cloud/vm/VirtualMachineManagerImplTest.java dd51e74
Diff: https://reviews.apache.org/r/11860/diff/
Testing
-------
Tested locally
Thanks,
Harikrishna Patnala
Re: Review Request: Fix for CLOUDSTACK-2502 and CLOUDSTACK-2939
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11860/#review21848
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On June 13, 2013, 10:42 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11860/
> -----------------------------------------------------------
>
> (Updated June 13, 2013, 10:42 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-2502: Scalevm and over provisioning should
> respect each other
>
> During Scale up of VM, memory/cpu calculations should consider the memory/cpu overprovisioning factors which are set per cluster.
>
> CLOUDSTACK-2939: CPU limit is not getting set for vm after scaleup to a service offering which have cpu cap enabled
>
>
> This addresses bugs CLOUDSTACK-2502 and CLOUDSTACK-2939.
>
>
> Diffs
> -----
>
> core/src/com/cloud/agent/api/ScaleVmCommand.java 35d22ad
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 46219c3
> plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java 3ca0b60
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e92c3fc
> plugins/hypervisors/xen/test/com/cloud/hypervisor/xen/resource/CitrixResourceBaseTest.java 3328d4b
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java d8945af
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 568fe55
> server/test/com/cloud/vm/VirtualMachineManagerImplTest.java dd51e74
>
> Diff: https://reviews.apache.org/r/11860/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: Fix for CLOUDSTACK-2502 and CLOUDSTACK-2939
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11860/#review21849
-----------------------------------------------------------
Commit b83b8eb838546197151d96e99ab3b9ee68db7df8 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b83b8eb ]
CLOUDSTACK-2502: Scalevm and over provisioning should respect each other
During Scale up of VM, memory/cpu calculations should consider the memory/cpu overprovisioning factors which are set per cluster.
CLOUDSTACK-2939: CPU limit is not getting set for vm after scaleup to a service offering which have cpu cap enabled
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On June 13, 2013, 10:42 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11860/
> -----------------------------------------------------------
>
> (Updated June 13, 2013, 10:42 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-2502: Scalevm and over provisioning should
> respect each other
>
> During Scale up of VM, memory/cpu calculations should consider the memory/cpu overprovisioning factors which are set per cluster.
>
> CLOUDSTACK-2939: CPU limit is not getting set for vm after scaleup to a service offering which have cpu cap enabled
>
>
> This addresses bugs CLOUDSTACK-2502 and CLOUDSTACK-2939.
>
>
> Diffs
> -----
>
> core/src/com/cloud/agent/api/ScaleVmCommand.java 35d22ad
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 46219c3
> plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java 3ca0b60
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e92c3fc
> plugins/hypervisors/xen/test/com/cloud/hypervisor/xen/resource/CitrixResourceBaseTest.java 3328d4b
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java d8945af
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 568fe55
> server/test/com/cloud/vm/VirtualMachineManagerImplTest.java dd51e74
>
> Diff: https://reviews.apache.org/r/11860/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: Fix for CLOUDSTACK-2502 and CLOUDSTACK-2939
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11860/#review21850
-----------------------------------------------------------
Commit b83b8eb838546197151d96e99ab3b9ee68db7df8 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b83b8eb ]
CLOUDSTACK-2502: Scalevm and over provisioning should respect each other
During Scale up of VM, memory/cpu calculations should consider the memory/cpu overprovisioning factors which are set per cluster.
CLOUDSTACK-2939: CPU limit is not getting set for vm after scaleup to a service offering which have cpu cap enabled
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On June 13, 2013, 10:42 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11860/
> -----------------------------------------------------------
>
> (Updated June 13, 2013, 10:42 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-2502: Scalevm and over provisioning should
> respect each other
>
> During Scale up of VM, memory/cpu calculations should consider the memory/cpu overprovisioning factors which are set per cluster.
>
> CLOUDSTACK-2939: CPU limit is not getting set for vm after scaleup to a service offering which have cpu cap enabled
>
>
> This addresses bugs CLOUDSTACK-2502 and CLOUDSTACK-2939.
>
>
> Diffs
> -----
>
> core/src/com/cloud/agent/api/ScaleVmCommand.java 35d22ad
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 46219c3
> plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java 3ca0b60
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e92c3fc
> plugins/hypervisors/xen/test/com/cloud/hypervisor/xen/resource/CitrixResourceBaseTest.java 3328d4b
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java d8945af
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 568fe55
> server/test/com/cloud/vm/VirtualMachineManagerImplTest.java dd51e74
>
> Diff: https://reviews.apache.org/r/11860/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>