You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "gustavodemorais (via GitHub)" <gi...@apache.org> on 2024/12/06 13:27:43 UTC
[PR] [FLINK-36840][table] Add correct call syntax for functions without `()` [flink]
gustavodemorais opened a new pull request, #25756:
URL: https://github.com/apache/flink/pull/25756
Backport of https://github.com/apache/flink/pull/25733
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
For Table API, there are 5 time-related functions that can't be called right now. This maps these the function calls for CURRENT_DATE, LOCALTIMESTAMP, LOCALTIME, CURRENT_TIMESTAMP, CURRENT_TIME currectly. These function do not support parenthesis when being called.
## Brief change log
- Add NO_PARENTHESIS call syntax
- Use it for CURRENT_DATE, LOCALTIMESTAMP, LOCALTIME, CURRENT_TIMESTAMP, CURRENT_TIME
- Update serialization tests
## Verifying this change
This change added tests and can be verified as follows:
- Added serialization tests to make sure the table api call get's mapped to the proper SQL Function
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: don't know
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36840][table] Add correct call syntax for functions without `()` [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25756:
URL: https://github.com/apache/flink/pull/25756#issuecomment-2523265735
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac0432df963ab7c9ddcd5ccd4cedb58e411cbaee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ac0432df963ab7c9ddcd5ccd4cedb58e411cbaee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac0432df963ab7c9ddcd5ccd4cedb58e411cbaee UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36840][table] Add correct call syntax for functions without `()` [flink]
Posted by "gustavodemorais (via GitHub)" <gi...@apache.org>.
gustavodemorais commented on PR #25756:
URL: https://github.com/apache/flink/pull/25756#issuecomment-2523501603
> Does the old syntax with `()` still work?
It never did. We might change that in another ticket. But right now, these five functions can only be called without parenthesis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36840][table] Add correct call syntax for functions without `()` [flink]
Posted by "gustavodemorais (via GitHub)" <gi...@apache.org>.
gustavodemorais commented on PR #25756:
URL: https://github.com/apache/flink/pull/25756#issuecomment-2523697208
> > > Does the old syntax with `()` still work?
> >
> >
> > It never did. We might change that in another ticket. But right now, these five functions can only be called without parenthesis.
>
> Sorry for the confusion. I meant to ask, after this change, do both syntaxes work?
What @snuyanzin said 👍 I'll look into making them also work with () in SQL, but we first wanted to mitigate the issue and make sure users can use the functions with table api
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36840][table] Add correct call syntax for functions without `()` [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #25756:
URL: https://github.com/apache/flink/pull/25756#issuecomment-2523702554
one finding which I think should be covered in follow-up issues.
Just noticed if you try to execute any from those 5 functions in FlinkSQL with `()` then the error message is wrong
```
select current_date();
[ERROR] Could not execute SQL statement. Reason:
org.apache.calcite.sql.validate.SqlValidatorException: No match found for function signature CURRENT_DATE().
Supported signatures are:
'CURRENT_DATE()'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36840][table] Add correct call syntax for functions without `()` [flink]
Posted by "jnh5y (via GitHub)" <gi...@apache.org>.
jnh5y commented on PR #25756:
URL: https://github.com/apache/flink/pull/25756#issuecomment-2523510673
> > Does the old syntax with `()` still work?
>
> It never did. We might change that in another ticket. But right now, these five functions can only be called without parenthesis.
Sorry for the confusion. I meant to ask, after this change, do both syntaxes work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36840][table] Add correct call syntax for functions without `()` [flink]
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys merged PR #25756:
URL: https://github.com/apache/flink/pull/25756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36840][table] Add correct call syntax for functions without `()` [flink]
Posted by "jnh5y (via GitHub)" <gi...@apache.org>.
jnh5y commented on PR #25756:
URL: https://github.com/apache/flink/pull/25756#issuecomment-2523492992
Does the old syntax with `()` still work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36840][table] Add correct call syntax for functions without `()` [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #25756:
URL: https://github.com/apache/flink/pull/25756#issuecomment-2523667825
>I meant to ask, after this change, do both syntaxes work?
no, this change is only about serialization of table api calls to correct (working) SQL
before the change it serialized to function calls with `()` which currently doesn't work (and didn't work in previous Flink versions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org